One comment to this commit.

On Fri, Mar 2, 2012 at 5:39 AM, Enlightenment SVN <
no-re...@enlightenment.org> wrote:

> Log:
> elev8: Remove HTTP module compile-time warnings
>
> Author:       acidx
> Date:         2012-03-01 12:39:19 -0800 (Thu, 01 Mar 2012)
> New Revision: 68596
> Trac:         http://trac.enlightenment.org/e/changeset/68596
>
> Modified:
>  trunk/PROTO/elev8/src/modules/http/elev8_http.cc
>
> Modified: trunk/PROTO/elev8/src/modules/http/elev8_http.cc
> ===================================================================
> --- trunk/PROTO/elev8/src/modules/http/elev8_http.cc    2012-03-01
> 20:28:22 UTC (rev 68595)
> +++ trunk/PROTO/elev8/src/modules/http/elev8_http.cc    2012-03-01
> 20:39:19 UTC (rev 68596)
> @@ -8,7 +8,7 @@
>  int XMLHttpRequest::fd_counter = 0;
>  Handle<ObjectTemplate> xmlHttpReqObj;
>
> -Eina_Bool data_callback(void *data, int type, void *event)
> +Eina_Bool data_callback(void *data, int, void *event)
>

Why not use __UNUSED__ like the rest of EFL.


>  {
>    Ecore_Con_Event_Url_Data *url_data = (Ecore_Con_Event_Url_Data *)event;
>    void *ptr = ecore_con_url_data_get(url_data->url_con);
> @@ -29,7 +29,7 @@
>    return EINA_FALSE;
>  }
>
> -Eina_Bool completion_callback(void *data, int type, void *event)
> +Eina_Bool completion_callback(void *data, int, void *event)
>  {
>    HandleScope handle_scope;
>    Ecore_Con_Event_Url_Complete *url_complete =
> (Ecore_Con_Event_Url_Complete *)event;
> @@ -81,7 +81,7 @@
>                out.write((char *)eina_binbuf_string_get(reqObj->data),
>                                   eina_binbuf_length_get(reqObj->data));
>                out.close();
> -               HTTP_INF(  "Size of response Data = %lu bytes",
> +               HTTP_INF(  "Size of response Data = %d bytes",
>
>  eina_binbuf_length_get(reqObj->data));
>                reqObj->responseText =  static_cast<Persistent<String>
> >(String::New(buf));
>             }
> @@ -126,8 +126,7 @@
>  }
>
>  Handle<Value>
> -response_text_getter(Local<String> property,
> -const AccessorInfo& info)
> +response_text_getter(Local<String>, const AccessorInfo& info)
>  {
>    Local<Object> self = info.Holder();
>    Local<External> wrap = Local<External>::Cast(self->GetInternalField(0));
> @@ -138,8 +137,7 @@
>  }
>
>  Handle<Value>
> -status_getter(Local<String> property,
> -const AccessorInfo& info)
> +status_getter(Local<String>, const AccessorInfo& info)
>  {
>    Local<Object> self = info.Holder();
>    Local<External> wrap = Local<External>::Cast(self->GetInternalField(0));
> @@ -149,8 +147,7 @@
>  }
>
>  Handle<Value>
> -readystate_getter(Local<String> property,
> -const AccessorInfo& info)
> +readystate_getter(Local<String>, const AccessorInfo& info)
>  {
>    Local<Object> self = info.Holder();
>    Local<External> wrap = Local<External>::Cast(self->GetInternalField(0));
> @@ -310,7 +307,7 @@
>    return Undefined();
>  }
>
> -Handle<Value> createXMLHttpReqInstance(const Arguments& args)
> +Handle<Value> createXMLHttpReqInstance(const Arguments&)
>  {
>    HandleScope scope;
>
>
>
>
> ------------------------------------------------------------------------------
> Virtualization & Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to