Thanks. I reviewed it.
I have some comments.
1) build warning.
There should be no even build warnings.
elm_entry.c: In function '_elm_entry_entry_paste':
elm_entry.c:1204:10: warning: assignment discards qualifiers from
pointer target type
Your change affected other widget. Please fix this even
elc_scrolled_entry is deprecated because it produces warnings
messages. So we can focus on other warnings.
elc_scrolled_entry.c: In function 'elm_scrolled_entry_cnp_textonly_set':
elc_scrolled_entry.c:190:1: warning: 'elm_entry_cnp_textonly_set' is
deprecated (declared at ./elm_deprecated.h:4408)
elc_scrolled_entry.c: In function 'elm_scrolled_entry_cnp_textonly_get':
elc_scrolled_entry.c:193:1: warning: 'elm_entry_cnp_textonly_get' is
deprecated (declared at ./elm_deprecated.h:4419)
2) formatting
Do not use space between ( and s.
if ( str != entry)
->
if (str != entry)
There is trailing whitespaces as well but others do not care about
this. So fixing this is up to you.
3) EINA_DEPRECATED In c.
Add EINA_DEPRECATED even in c. It's a mark so we can recognize it
while working on c.
4) use -x -up option
Use -x -up option for svn. it shows function name for each diff.
$ svn diff -x -up
5) Widget_Data
In Widget_Data, I recommend to move cnp_mode at the end of other one
bit members for optimized memory packing.
Eina_Bool autosave : 1;
- Eina_Bool textonly : 1;
+ Elm_CNP_Mode cnp_mode : 2;
Eina_Bool usedown : 1;
6) Elm_CNP_Mode
This enum name format is different from EFL's other enums.
Aaa_Aaa_Aaa is normal in EFL. I know CNP is a abbreviation but I'm not
sure we have an exception here or not.
Can anybody else has any idea on this?
And, I recommend you to read following wiki page for patch.
http://trac.enlightenment.org/e/wiki/PatchReview
Otherwise, look ok to me.
Thanks.
Daniel Juyung Seo (SeoZ)
2012/3/2 김대성 <[email protected]>:
>
> Dear. All elementary library developers.
>
> I resolved svn merge conflict.
> Thank you for approving this patch.
> Best regards.
>
> -----Original Message-----
> From: "Carsten Haitzler"<[email protected]>
> To: "김대성"<[email protected]>
> Cc: [email protected]
> Sent: 12-03-01(목) 20:07:40
> Subject: Re: [E-devel] suggest new api for elm_entry's copy & paste behavior
> On Mon, 27 Feb 2012 16:19:00 +0900 김대성<[email protected]> said:
> approved - but it doesn't apply anymore. can you merge and re-submit - anyone
> please commit it when it comes in. :) (i'm away from home/work right now and
> might miss it)
>>
>> Dear. All elementary library developers.
>>
>> I deprecated old apis(elm_entry_cnp_textonly_set/get) in this patch.
>> Please review this patch once again.
>>
>> Best regards.
>> -----Original Message-----
>> From: "Carsten Haitzler"<[email protected]>
>> To: "Enlightenment developer
>> list"<[email protected]> Cc: "김대
>> 성"<[email protected]> Sent: 12-02-24(금) 18:49:29
>> Subject: Re: [E-devel] suggest new api for elm_entry's copy & paste behavior
>> On Fri, 17 Feb 2012 17:45:57 +0900 김대성<[email protected]> said:
>> could you provide this new api and ALSO deprecate the old apis so we dont
>> have
>> an instant api break? (we can deprecate and move over the next few
>> days/weeeks)?
>> >
>> > Dear. All elementary developer.
>> >
>> > Attached to the mail is the patch for new API.
>> > This patch changes elm_entry_cnp_test_only_set/get APIs to
>> > elm_entry_cnp_mode_set/get APIs.
>> > Patch is useful for 3 cases when copy&paste through entry in application.
>> > case 1 : get original markup text
>> > case 2 : get markup text without image
>> > case 3 : get plain text
>> >
>> > CNP_MODE can be set these values.
>> > EML_CNP_MODE_MARKUP : any tags are not removed.
>> > EML_CNP_MODE_NO_IMAGE : just removes all item tags.
>> > EML_CNP_MODE_PLAINTEXT : removes all item tags, fonts and color tags.
>> >
>> > Please review this patch.
>> >
>> > Best regards.
>> --
>> ------------- Codito, ergo sum - "I code, therefore I am" --------------
>> The Rasterman (Carsten Haitzler) [email protected]
> --
> ------------- Codito, ergo sum - "I code, therefore I am" --------------
> The Rasterman (Carsten Haitzler) [email protected]
>
> ------------------------------------------------------------------------------
> Virtualization & Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
