I updated PatchReview wiki for "no #ifdef for headers" http://trac.enlightenment.org/e/wiki/PatchReview Thanks :)
Daniel Juyung Seo (SeoZ) On Wed, Mar 7, 2012 at 6:26 PM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Mon, 5 Mar 2012 20:05:51 +0900 Bluezery <ohpo...@gmail.com> said: > > ergh. trouble. > > 1. never #ifdef things in a header - ie the emap apis - never make them > optional based on a ifdef - ever. it broke for me as i dont have emap here. i > modified this to always provide these funcs, but just have empty > implementations if no emap is there. > 2. you use lots of deprecated calls in the test - i commented them out with > FIXME: deprecated comments, so test may be broken now. > 3. elm_deprecated.h had a patch that made no sense removing index deprectaed > apis etc. didn't apply that. > > so please do this: > > 1. export CFLAGS="-W -Wall -Wextra -Wshadow" > > make sure there are no warnings before u submit. > > 2. never #fidef apis optionally in a header (there is a rare case - maybe, you > want this - but as a general rule - never do it). > > otherwise with fixes, applied. > >> Hello, >> >> I rename & add some APIs. >> As previously discussed, I categorized map APIs. >> (http://marc.info/?l=enlightenment-devel&m=132685497711772&w=2) >> >> 1) Zoom >> elm_map_zoom_set/get >> elm_map_zoom_mode_set/get >> elm_map_zoom_min_set/get >> elm_map_zoom_max_set/get >> >> 2) Region - Geographic coordinates (region) >> elm_map_region_get >> elm_map_region_show/bring_in >> elm_map_canvas_to_region_convert >> >> I will not use "_geo_" in map APIs. All map APIs are basically used by >> geographic coordinates. >> >> 3) Property >> elm_map_paused_set/get >> elm_map_rotate_set/get >> elm_map_wheel_disabled_set/get >> elm_map_user_agent_set/get >> >> 4) Overlay >> elm_map_overlay_add/del >> elm_map_overlay_xxx >> elm_map_overlay_class_xxx >> elm_map_overlay_bubble_xxx >> elm_map_overlay_route_xxx >> >> I will add line, rectangle, poi overlays ASAP. >> >> 5) Source - External Provider (Tile, Route, Name, ) >> elm_map_sources_get >> elm_map_source_set/get >> >> I will add more provider ASAP such as POI, etc. >> >> 6) Route >> elm_map_route_add/del >> elm_map_route_distance_get >> elm_map_route_node_get >> elm_map_route_waypoints_get >> >> 7) Name >> elm_map_name_add/del >> elm_map_route_address_get >> elm_map_route_region_get >> >> 6) Route and 7) Name do not return visible objects actually. Those >> just return data. >> I don't know "_add" suffix is correct for none visible objects. >> I cannot decide yet whether those should be removed from map widget. >> But current trends are that route, geocoding are tightly coupled with Map. >> >> If Apps want to use only data, just use elm_map_route_add(). >> If not, use elm_map_route_add() & elm_map_overlay_route_add(). >> Also name overlay could be added in the future. >> >> 8) Miscellaneous >> elm_map_tile_load_status_get >> >> 9) Signals >> Basic events : "clicked", "clicked,double", "press", "longpressed", >> Scroller events: "scroll", "scroll,xxx,xxx" >> Zoom events: "zoom,start/stop/change" >> Source (provider) events: "tile,load/loaded/loaded,fail" , >> "route,load/loaded/loaded,fail", "name,load/loaded/loaded,fail" >> >> There are some big patches. I think diff program do not make exact diff. :D. >> Anyway, it's better to maintain if this can be in before API fix >> (elementary 1.0). >> Because after these change, It is hard to maintain old APIs. >> >> PS) Documentations and some minor bugs are remained yet. >> >> Thanks >> -- >> BRs, >> Kim. > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > ------------------------------------------------------------------------------ > Virtualization & Cloud Management Using Capacity Planning > Cloud computing makes use of virtualization - but cloud computing > also focuses on allowing computing to be delivered as a service. > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
