On Mon, Apr 2, 2012 at 11:58 AM, Tom Hacohen <tom.haco...@samsung.com> wrote: > > Bug reports, comments, suggestions, or whatever are more than welcomed!
eobj.h --> Eobj.h (like all other EFL) missing EAPI definition in eobj.h eina_log.h inclusion useless in eobj.c missing EAPI in front of eobj_ref() in eobj.c I like to give a namespace to variables even if they are static (like classes --> _eobj_classes, same for classes_last_id. You did it for the log domain, so do it for the others) missing _ in front of eobj_class_constructor() and _eobj_class_destructor() wrong indentation struct { should be : struct { better organise eobj.c (a bit messy). In order: macro typedef struct static functions API same for eobj.h (without static fcts of course) question : why struct _Eobj { Eobj *parent; *** }; instead of struct _Eobj { Eobj parent; *** }; ? it should compile on Windows at first sight Vincent ------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel