On Wed, Apr 18, 2012 at 7:28 PM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Wed, 18 Apr 2012 10:50:53 +0900 Daniel Juyung Seo <seojuyu...@gmail.com> > said: > >> Hello, >> I agree with this change but I'm sad that Elm_Object_Select_Mode is >> not reusable here :( >> If we need to add Elm_Calendar_Select_Mode enum, I recommend to rename them. >> So my suggestion is >> >> typedef enum >> { >> ELM_CALENDAR_SELECT_MODE_ALWAYS, >> ELM_CALENDAR_SELECT_MODE_NONE, >> ELM_CALENDAR_SELECT_MODE_ONDEMAND >> } Elm_Calendar_Select_Mode; > > what does ONDEMAND do? also if we do this make it: > > ELM_CALENDAR_SELECT_MODE_DEFAULT = 0, > ELM_CALENDAR_SELECT_MODE_ALWAYS, > ELM_CALENDAR_SELECT_MODE_NONE, > ELM_CALENDAR_SELECT_MODE_ONDEMAND // <- whatever that is? > > at least it matches numerically to Elm_Object_Select_Mode in case people stuff > up and use the wrong enum. :) so michael - pls make a patch and send in asap!
Yes this is better. (actually I considered using DEFAULT.) The name ELM_CALENDAR_SELECT_MODE_ONDEMAND is what I suggested. Yoz proposed ELM_CALENDAR_SELECT_USER though. Anyhow both are ambiguous. From my understanding, there should have any selected day even though the user did not select one. ELM_CALENDAR_SELECT_MODE_ONDEMAND allows none of days is selected at some point. So only when the day is selected by API or user interaction, it can be selected. I also want to have yoz's patch. Thanks. Daniel Juyung Seo (SeoZ) > >> Thanks. >> >> Daniel Juyung Seo (Seoz) >> >> 2012/4/18 Michaël Bouchaud <y...@efl.so>: >> > ---------- Forwarded message ---------- >> > From: Michaël Bouchaud <y...@efl.so> >> > Date: 2012/4/18 >> > Subject: queue 1 >> > To: Enlightenment users discussion & support < >> > enlightenment-us...@lists.sourceforge.net> >> > >> > >> > Hi all, >> > I come here about release, I want made some changes to elm_calendar in >> > future. >> > Here is the problem about this widget. You have only two choice, user can't >> > select >> > a day, second one user has always selected a day. I want introduce a third >> > choice, user >> > could have not selected a day. >> > So we go to release soon, near to freeze the beta and my patch isn't ready >> > :(. So I think about futur. >> > I just want deprecate elm_calendar_day_selecion_disabled_set and get func. >> > So I replace it by >> > elm_calendar_select_mode_set(Evas_object, Elm_Calendar_Select_Mode(enum)) / >> > get func. Where >> > mode are for now ELM_CALENDAR_SELECT_ALWAYS, ELM_CALENDAR_SELECT_NEVER. I >> > will >> > introduce in futur (soon, I hope) ELM_CALENDAR_SELECT_USER. >> > What do you think? >> > >> > -- >> > Michaël Bouchaud (yoz) <y...@efl.so> >> > >> > >> > >> > >> > -- >> > Michaël Bouchaud (yoz) <y...@efl.so> >> > ------------------------------------------------------------------------------ >> > Better than sec? Nothing is better than sec when it comes to >> > monitoring Big Data applications. Try Boundary one-second >> > resolution app monitoring today. Free. >> > http://p.sf.net/sfu/Boundary-dev2dev >> > _______________________________________________ >> > enlightenment-devel mailing list >> > enlightenment-devel@lists.sourceforge.net >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> ------------------------------------------------------------------------------ >> Better than sec? Nothing is better than sec when it comes to >> monitoring Big Data applications. Try Boundary one-second >> resolution app monitoring today. Free. >> http://p.sf.net/sfu/Boundary-dev2dev >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > ------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel