Hey,
Thanks a lot for doing these reports/docs.
The code reduction seems impressive, and just shows again that we have
delayed this change for too long. :) Will also reduce the number of API
I assume, and that's great.
Regarding the image: I was thinking more of an inheritance graph of the
whole elm widgets, i.e:
Elm_Widget
/ \
Elm_Container Elm_Foo
| |
Elm_Box Elm_Bar
|
Elm_Button
Just to understand the new inheritance design you chose, which in my
pov, is more important than the actual implementation details. The
inheritance design is "visible" to users of the API, while internal
implementation is not.
Again, thanks a lot for all the info.
Is there anything in specific you want people to test/review? I.e you
want more detailed examination of the API or of the internals? Please
elaborate. I can't promise anything, but soon enough I'll have to jump
in and read as well, as some of my team's future work is related.
--
Tom.
On 25/04/12 22:24, Gustavo Chaves wrote:
> Bump again.
>
> Both http://people.profusion.mobi/~glima/elm/group__Widget.html
> and http://git.profusion.mobi/cgit.cgi/glima/elementary/ are updated.
>
> Tom, there's an image there illustrating the old and new class schemas
> side by side, now. Enjoy.
>
> I'd be vary glad to have people testing and reviewing too.
>
> Tom, here's a (maybe outdated, by now, because of constant rebases)
> table on code reduction based on number of semi-colons. I used this
> metric to be more fair, taking in account that I wiped up all widgets,
> ecrustifying them and letting all fine, apart from porting.
>
> File Original code New code Reduction
> elm_bubble.c 186 67 63%
> elm_button.c 264 130 51%
> elm_check.c 249 126 49%
> elm_frame.c 174 90 48%
> elm_radio.c 265 162 39%
> elm_slider.c 562 385 31%
>
> Cheers.
>
> On Tue, Apr 3, 2012 at 3:06 PM, Gustavo Chaves <gl...@profusion.mobi
> <mailto:gl...@profusion.mobi>> wrote:
>
> Just a bump on the matter: git repo for analisys rebased and updated.
>
>
> On Tue, Apr 3, 2012 at 10:40 AM, Tom Hacohen
> <tom.haco...@samsung.com <mailto:tom.haco...@samsung.com>> wrote:
>
> On 03/04/12 16:36, Gustavo Chaves wrote:
>
> Will be done, don't worry :)
>
>
> I'm not worried, but this is probably the easiest thing to
> review and gives a lot of info.
>
>
> I'll make # of semicolon comparisons per widget file, later.
>
> Yay, thanks.
>
> Perfectly working.
>
>
> Great. :)
>
> --
> Tom.
>
>
>
>
> --
> Gustavo Lima Chaves
> Senior Developer
> ProFUSION embedded systems
> http://profusion.mobi
>
>
>
>
> --
> Gustavo Lima Chaves
> Senior Developer
> ProFUSION embedded systems
> http://profusion.mobi
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
