Enabled during build by default is perfectly acceptable :) I was simply saying that IMO it should not be an enabled module by default in the standard config profile ;)
Quick, someone with commit access please put this in !! :) (no commits here from work just yet) Cheers, dh ----- Original Message ----- From: "Stefan Schmidt" <ste...@datenfreihafen.org> To: "Christopher Michael" <cpmicha...@comcast.net> Cc: "Enlightenment developer list" <enlightenment-devel@lists.sourceforge.net>, "Stefan Schmidt" <ste...@datenfreihafen.org>, "Carsten Haitzler" <ras...@rasterman.com> Sent: Wednesday, 2 May, 2012 7:33:51 AM Subject: Re: [E-devel] [PATCH] Bring tiling module from EXTRAS into core Hello. On Tue, 2012-05-01 at 19:23, Christopher Michael wrote: > > If the patches are in order, and no build problems, then ++ here. > However, I do not believe it should be "enabled" by default. Tiling > in E17 is not a 'default' behavior (not everyone uses it or likes > it), therefore should not be 'enabled' by default in most config > profiles. That's my only objection. That aside, the code is nice, > functional, and acceptable. In it goes (not enabled by default, but > certainly easily available). Hmm, the building of the module is enabled by default. It still needs to be loaded by the user or a profile (no profile does this right now) to be used. I enabled the building so it is easier to spot for users that it is available without being hidden behind a configure flag. If this is not accaptable I will send an updated patch which disables the build by default. regards Stefan Schmidt ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
