Hello. Shinwoo.
Here are my comments. 1. We need to keep the internal signal emits for backward compatibility. if there are apps which customized diskselector styles, they would be broken. So please just leave them and leave TODOs: remove these signals later 2.0 2.Rotation effect looks really awful. How about making the rotation range 0 ~ 45 ? or less then 45. Even there are some magic numbers (0.2, 90) could be configurable but it's ok to me to modify them later since they are not important right now. ------------------------------------ -Regards, Hermet- -----Original Message----- From: "Kim Shinwoo"<kimcinoo....@gmail.com> To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; Cc: Sent: 2012-04-30 (월) 16:32:06 Subject: Re: [E-devel] [Patch] elm_diskselector, set icon to added item I'm glad to get your response. The revised patch has been attached. Please review the patch.. Thanks! Sincerely, Shinwoo Kim. 2012/4/30 Daniel Juyung Seo <seojuyung2>@gmail.com>: > The effect looks good to me. > Comments here. > > 1. indentation in your patch. > line 79 > line 115 ~ 136 > > 2. more braces for if > if (x + (w / 2) < ox + (0.2 * ow)) > --> > if ((x + (w / 2)) < (ox + (0.2 * ow))) > > you need more braces for other if statements. > > I'll wait for other's comments about map. > Thanks. > > Daniel Juyung Seo (SeoZ) > > > > > On Mon, Apr 30, 2012 at 8:31 AM, Kim Shinwoo <kimcinoo.efl>@gmail.com> wrote: >> Thanks for your response! >> >> I have updated the previous patch based on your comments. >> The indentation.. it is difficult to find where it is.. please enlighten me. >> Effects.. definitely.. :) >> >> Sincerely, >> Shinwoo Kim. >> >> 2012/4/27 Hyoyoung Chang <hyoyoung>@gmail.com>: >>> On Fri, Apr 27, 2012 at 3:55 PM, cnook <kimcinoo>@gmail.com> wrote: >>>> Dear all, hello. >>>> >>>> I have tried to use the map with the diskselector. >>>> The attached patch is just draft version for using map. >>> >>> Is it really draft version? imho, it's too good to be initial version. >>> i just found few points which can be improved. >>> >>> 1. >>> + if (map == NULL) return EINA_FALSE >>> -> if (!map) >>> >>> 2. indentation near about evas_map_smooth_set() >>> >>> 3. as you said, effects can be more tailored. >>> >>>> >>>> BUT.. just remind the Raster's comment "at least it can retain its api"... >>>> I removed number of letters feature.. when I had changed the diskselector... >>>> So.. even though an item of diskselector moves right or left side.. the >>>> item will keep its number of letters.. >>>> means... elm_diskselector_side_text_max_length_set does not work.. >>>> anyhow.. this is the draft version.. I would like to check that the map is >>>> used properly.. as the Raster's recommends "it really needs to use map" >>>> >>>> >>>> Please review the attached patch. Thanks. >>>> >>>> Sincerely, >>>> Shinwoo Kim. >>>> >>>> >>>> 2011/10/10 Carsten Haitzler <raster>@rasterman.com> >>>> >>>>> On Mon, 10 Oct 2011 22:45:56 +0900 Daniel Juyung Seo <seojuyung2>@gmail.com >>>>> > >>>>> said: >>>>> >>>>> at least it can retain its api. :) >>>>> >>>>> > Wow this sounds like diskselector needs to be rewritten a lot. >>>>> > >>>>> > Daniel Juyung Seo (SeoZ) >>>>> > >>>>> > On Mon, Oct 10, 2011 at 6:45 PM, Carsten Haitzler <raster>@rasterman.com> >>>>> > wrote: >>>>> > > On Thu, 22 Sep 2011 18:39:53 +0900 cnook <kimcinoo>@gmail.com> said: >>>>> > > >>>>> > >> Dear All, Hello! >>>>> > >> >>>>> > >> If the diskselector is round mode, the scroller of diskselector has >>>>> > >> additional items for its rounding(carousel) effect. >>>>> > >> Previously, elm_diskselector_item_icon_set(); did not care about >>>>> > >> theses additional items. >>>>> > >> Please review the attached patch that will care. Thanks. >>>>> > > >>>>> > > hmm ok - in svn. not giving this a lot of review. i was reviewing >>>>> > > diskselector about a week ago or so and realized.. this widget needs a >>>>> > > major overhaul in internal design and implementation. to implement a >>>>> > > rounded disk - it really needs to use map, and even then the amount of >>>>> > > rounding or if any at all should be configurable. it should almost >>>>> > > definitely implement this with a pan smart like genlist does to allow >>>>> for a >>>>> > > virtual pan area (we can make it almost infinite - well make it just >>>>> very >>>>> > > very very very large) and based on position int he virtual pan, >>>>> position >>>>> > > children (really just use a box with map used to duplicate it on the >>>>> curved >>>>> > > or visibile area). >>>>> > > >>>>> > > -- >>>>> > > ------------- Codito, ergo sum - "I code, therefore I am" >>>>> -------------- >>>>> > > The Rasterman (Carsten Haitzler) ras...@rasterman.com >>>>> > > >>>>> > > >>>>> > > >>>>> ------------------------------------------------------------------------------ >>>>> > > All the data continuously generated in your IT infrastructure contains >>>>> a >>>>> > > definitive record of customers, application performance, security >>>>> > > threats, fraudulent activity and more. Splunk takes this data and makes >>>>> > > sense of it. Business sense. IT sense. Common sense. >>>>> > > http://p.sf.net/sfu/splunk-d2dcopy1 >>>>> > > _______________________________________________ >>>>> > > enlightenment-devel mailing list >>>>> > > enlightenment-devel@lists.sourceforge.net >>>>> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>>>> > > >>>>> > >>>>> > >>>>> ------------------------------------------------------------------------------ >>>>> > All the data continuously generated in your IT infrastructure contains a >>>>> > definitive record of customers, application performance, security >>>>> > threats, fraudulent activity and more. Splunk takes this data and makes >>>>> > sense of it. Business sense. IT sense. Common sense. >>>>> > http://p.sf.net/sfu/splunk-d2dcopy1 >>>>> > _______________________________________________ >>>>> > enlightenment-devel mailing list >>>>> > enlightenment-devel@lists.sourceforge.net >>>>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>>>> > >>>>> >>>>> >>>>> -- >>>>> ------------- Codito, ergo sum - "I code, therefore I am" -------------- >>>>> The Rasterman (Carsten Haitzler) ras...@rasterman.com >>>>> >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Live Security Virtual Conference >>>> Exclusive live event will cover all the ways today's security and >>>> threat landscape has changed and how IT managers can respond. Discussions >>>> will include endpoint security, mobile security and the latest in malware >>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>>> _______________________________________________ >>>> enlightenment-devel mailing list >>>> enlightenment-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Live Security Virtual Conference >>> Exclusive live event will cover all the ways today's security and >>> threat landscape has changed and how IT managers can respond. Discussions >>> will include endpoint security, mobile security and the latest in malware >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>> _______________________________________________ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
