2012/5/21 Daniel Juyung Seo <[email protected]>:
> Yes, Hermet is right.
> Btw, bluezery, is there any problem with this code?
> Daniel Juyung Seo (SeoZ)

No problem actually :)
But elm_win holds NULL sub-object after ctx_popup is deleted.  This is
a potential problem.
And error message is unpleasant to me  :(

> On Mon, May 21, 2012 at 7:13 PM, ChunEon Park <[email protected]> wrote:
>> No. It should be called when parent is changed with 
>> elm_ctxpopup_hover_parent_set.
>> In this case, parent wouldn't be deleted.

Yes, you're right.
I fixed my patch.  elm_widget_sub_object_del() is called in
elm_ctxpopup_hover_parent_set(), not in _parent_cut_off().

But in this patch, _parent_cut_off() function do not cut off all
parent things. There may need to change the function name.

>>
>>
>> ------------------------------------
>>
>> -Regards, Hermet-
>>
>> -----Original Message-----
>> From: "Bluezery"&lt;[email protected]&gt;
>> To: "Enlightenment developer 
>> list"&lt;[email protected]&gt;;
>> Cc:
>> Sent: 2012-05-21 (월) 17:32:15
>> Subject: [E-devel] [Patch][elc_ctxpopup] Remove
>>
>> Hello,
>>
>> When ctx_popup is deleted, it calls "elm_widget_sub_object_del(parent,
>> popup)" so that ctx_popup's parent can delete it's sub_ojbect,
>> "ctx_popup".
>> But this is not needed because parent already deletes it's sub-object
>> in elm_widget.c
>>
>> Thanks
>>
>> --
>> BRs,
>> Kim.
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. 
>> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________
>> enlightenment-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> enlightenment-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel



-- 
BRs,
Kim.

Attachment: ctxpopup@remove_unnecessary_code.patch
Description: Binary data

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to