On Wed, May 23, 2012 at 1:02 AM, Leandro Pereira <lean...@profusion.mobi> wrote:
> On Mon, May 21, 2012 at 10:35 PM, Enlightenment SVN
> <no-re...@enlightenment.org> wrote:
>>    cnp_debug("Got some HTML: Checking encoding is useful\n");
>>    data = notify->data;
>> +   char *stripstr = malloc(sizeof(char) * (data->length + 1));
>
> sizeof(char) is 1 by definition. Just malloc(data->length + 1).

ok
>
>>         ddata.format = ELM_SEL_FORMAT_HTML;
>> -        ddata.data = data->data;
>> +        ddata.data = stripstr;
>>         ddata.len = data->length;
>
> Haven't checked the code to see how ddata.data is used afterwards, but
> this looks pretty wrong to me.
then mail me after checking :P
i added free stripstr routine.

Thanks
>
> --
>   Leandro
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to