On Thu, 24 May 2012 14:21:33 +0900 Bluezery <ohpo...@gmail.com> said:
> Dear EFL developers, > > I want to add new "loaded" signal to elementary map. This signal > notify users when all map tiles are loaded. Timer is used for this > signal. > Currently "tile,loaded" can be used for each separated tile. So the > users are hard to know whether all tiles are loaded or not. > Please review this patch. you missed: 1. changelog 2. docs about new signal 3. since 1.1 for new signal in docs 4. u forgot to delete the timer when widget is deleted 5. better set timer to null BEOFRE u call the callback, not after - app code can run and play with map again from inside that callback, thus affecting the timer ptr value implicitly. :) in svn with fixes fop the above. :) i'm in a good mood. :) nb - i like the patch size. small. digestible. easy to read, figure out, spot the issues and fix them. :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
