On Fri, May 25, 2012 at 4:29 PM, ChunEon Park <her...@naver.com> wrote: > > But even I changed API, I didn't change actual return value. > Just changed API but It still returns previous int type value.
as an enum can be implemented with a type different than an int, yes for example : -fshort-enums option of gcc (see : http://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#Code-Gen-Options) Vincent > > Really does it cause ABI break? > > ------------------------------------ > -Regards, Hermet- > > -----Original Message----- > From: "Carsten Haitzler"<ras...@rasterman.com> > To: "Enlightenment developer > list"<enlightenment-devel@lists.sourceforge.net>; > Cc: > Sent: 2012-05-25 (금) 21:29:12 > Subject: Re: [E-devel] E SVN: hermet IN trunk/ecore: . src/lib/ecore_x > src/lib/ecore_x/xcb src/lib/ecore_x/xlib > > On Fri, 25 May 2012 13:47:35 +0200 Vincent Torri > <vincent.torri>@gmail.com> said: > > correct, though only in odd cases. i dont know of any compiler that uses > something other than an int for an enum. is generally not a good idea to > change > types of returns or arguments. > > > according to raster, you can break ABI by changing that, as the > > implementation of an enum can vary from a compiler to another > > > > Vincent > > > > On Fri, May 25, 2012 at 12:15 PM, Enlightenment SVN > > <no-reply>@enlightenment.org> wrote: > > > Log: > > > ecore/ecore_x - Changed ecore_x_error_get() return type to > > > Ecore_X_Error_Code from int > > > > > > > > > > > > Author: hermet > > > Date: 2012-05-25 03:15:27 -0700 (Fri, 25 May 2012) > > > New Revision: 71421 > > > Trac: http://trac.enlightenment.org/e/changeset/71421 > > > > > > Modified: > > > trunk/ecore/ChangeLog trunk/ecore/src/lib/ecore_x/Ecore_X.h > > > trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_error.c > > > trunk/ecore/src/lib/ecore_x/xlib/ecore_x.c > > > trunk/ecore/src/lib/ecore_x/xlib/ecore_x_error.c > > > > > > Modified: trunk/ecore/ChangeLog > > > =================================================================== > > > --- trunk/ecore/ChangeLog 2012-05-25 09:19:16 UTC (rev 71420) > > > +++ trunk/ecore/ChangeLog 2012-05-25 10:15:27 UTC (rev 71421) > > > @@ -682,4 +682,8 @@ > > > timer around, quit mainloop, then start it again expecting > the timer > > > to keep ticking off. also happens to be an issuw with > > > iterating the mainloop. > > > - > > > + > > > +2012-05-25 ChunEon Park (Hermet) > > > + > > > + * Changed ecore_x_error_get() return type to > Ecore_X_Error_Code > > > from > > > + int > > > > > > Modified: trunk/ecore/src/lib/ecore_x/Ecore_X.h > > > =================================================================== > > > --- trunk/ecore/src/lib/ecore_x/Ecore_X.h 2012-05-25 09:19:16 > UTC > > > (rev 71420) +++ trunk/ecore/src/lib/ecore_x/Ecore_X.h > 2012-05-25 > > > 10:15:27 UTC (rev 71421) @@ -1255,9 +1255,11 @@ > > > ecore_x_io_error_handler_set(void (*func)(void *data), > > > const void *data); > > > EAPI int > > > - ecore_x_error_request_get(void); > > > -EAPI int > > > - ecore_x_error_code_get(void); > > > +ecore_x_error_request_get(void); > > > + > > > +EAPI Ecore_X_Error_Code > > > +ecore_x_error_code_get(void); > > > + > > > EAPI Ecore_X_ID > > > ecore_x_error_resource_id_get(void); > > > > > > > > > Modified: trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_error.c > > > =================================================================== > > > --- trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_error.c 2012-05-25 > 09:19:16 > > > UTC (rev 71420) +++ > trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_error.c > > > 2012-05-25 10:15:27 UTC (rev 71421) @@ -58,7 +58,7 @@ > > > * > > > * Return the error code from the last X error > > > */ > > > -EAPI int > > > +EAPI Ecore_X_Error_Code > > > ecore_x_error_code_get(void) > > > { > > > return _error_code; > > > > > > Modified: trunk/ecore/src/lib/ecore_x/xlib/ecore_x.c > > > =================================================================== > > > --- trunk/ecore/src/lib/ecore_x/xlib/ecore_x.c 2012-05-25 09:19:16 > UTC > > > (rev 71420) +++ trunk/ecore/src/lib/ecore_x/xlib/ecore_x.c > 2012-05-25 > > > 10:15:27 UTC (rev 71421) @@ -1228,7 +1228,7 @@ > > > _ecore_x_window_manage_error(void *data __UNUSED__) > > > { > > > if ((ecore_x_error_request_get() == X_ChangeWindowAttributes) > && > > > - (ecore_x_error_code_get() == BadAccess)) > > > + (ecore_x_error_code_get() == ECORE_X_ERROR_CODE_BAD_ACCESS)) > > > _ecore_x_window_manage_failed = 1; > > > } > > > > > > > > > Modified: trunk/ecore/src/lib/ecore_x/xlib/ecore_x_error.c > > > =================================================================== > > > --- trunk/ecore/src/lib/ecore_x/xlib/ecore_x_error.c 2012-05-25 > 09:19:16 > > > UTC (rev 71420) +++ trunk/ecore/src/lib/ecore_x/xlib/ecore_x_error.c > > > 2012-05-25 10:15:27 UTC (rev 71421) @@ -69,7 +69,7 @@ > > > * > > > * Return the error code from the last X error > > > */ > > > -EAPI int > > > +EAPI Ecore_X_Error_Code > > > ecore_x_error_code_get(void) > > > { > > > return _error_code; > > > > > > > > > > ------------------------------------------------------------------------------ > > > Live Security Virtual Conference > > > Exclusive live event will cover all the ways today's security and > > > threat landscape has changed and how IT managers can respond. > Discussions > > > will include endpoint security, mobile security and the latest in > malware > > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > > _______________________________________________ > > > enlightenment-svn mailing list > > > enlightenment-...@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
