Hi, We designed the module based approach for mainly the following reasons:
1. Default indicator is displayed at the top of touch area. What if we want to show the popup at the left side/ right side/ bottom of the touch point? - A dedicated dynamic module can handle the indicator orientation in the module code itself. 2. There may be some cases where we need to display indicator popup in a separate window. It is left up to the module to decide how & where to display. So considering the above extendibility options, we proposed the Slider indicator modular approach. More over it will not change current indicator style. If you feel that there is no need for these enhancements, we can very well bring the feature in the widget code itself. I can make a patch with the default indicator, always showing on the top of touch area. Thanks & Regards, Sumanth > On Thu, 24 May 2012 15:02:05 -0300 Gustavo Sverzut Barbieri > <barbieri@...> said: > > > Hi Sumanth, > > > > Thanks for the explanation, NOW it's much better to decide what to do! :-) > > See some comments below: > > > > On Thu, May 24, 2012 at 12:17 PM, Sumanth Krishna Mannam > > <sumanth.m@...> wrote: > > > Hi , > > > > > > Indicator popup UI is already implemented as an edc style based feature. > > > But the concern is about layering ( refer to earlier discussions on the > > > same: > > > http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg41014.html > > > ) > > > - the current design cannot bring the slider indicator on to a top layer. > > > > > > If we pack slider inside a genlist, the portion of Slider indicator that > > > is > > > beyond the genlist item area is been clipped, causing the problem. > > > > > > To display the full indicator, we need to move portion of edj object part > > > to a higher layer which against EDJE Object design. > > > > > > To overcome this, we have to use a different edj object to stack up in the > > > widget C code. With further enhancement of this, Module design allows us > > > to > > > customize the indicator object. > > > > > > So we are proposing the indicator popup module for elm_slider widget. > > > > As far as I understand, the current popup was done as an Edje show > > case... it's possible, simple... why not?! Then it got in. > > > > However, as you mentioned there is a stacking problem. Given that the > > popup is nice and I see it being used in most of the cases... why not > > make it default, instead of a module? > > > > The idea would be that there is a new group and if it exists, it's > > used as the popup. The old themes should still work as they do... and > > no extra module is needed. > > > > If you agree with that, then please provide a new patch. > > > > Again, thanks for your explanation of the problem :-) > i agree. there is no need for a module. modules should only be used if you > REALLy need to make some core logic pluggable and different from environment > to > environment and either for legal or other reasons the code can't be in > elementary OR it's too big/complex to be in elementary OR that it adds > dependencies which are unreasonable to impose on everyone. :) > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) raster@... ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel