On Mon, May 28, 2012 at 5:41 PM, Gustavo Lima Chaves <gl...@profusion.mobi> wrote: > > * Enlightenment SVN <no-re...@enlightenment.org> [2012-05-28 13:35:35 -0700]: > > > Log: > > [elm] Warn about deprecation of some icon calls > > The ones just wrapping their image counterparts should die eventually. > > The signal callbacks on icons will die, too, eventually. > > Dear people, > > as you can see, I have marked some icon calls as deprecated, since now > it shares a common base with image. Various of its API calls just pass > down the job to the image counterpart, so let's warn users as early as > possible of a future dropping of the icon versions of those.
IMO we should be louder and add EINA_DEPRECATED to these things, also marking them in ChangeLog/NEWS for future removal. Maybe we deprecate now (as in EINA_DEPRECATED) and remove in 2.0 or 3.0? > I'd also like to warn the elm_image's original implementor(s) that, a > line that I kept, > > evas_object_event_callback_add > (img, EVAS_CALLBACK_MOUSE_UP, _on_mouse_up, obj); > > is buggy and waiting for bad things to happen. This should ideally be > taken care of as Edje does, before emitting a 'clicked' signal -- we > gotta track if the mouse down was also done inside the object and > so. Please prove me wrong, if it's the case. Yes, blindly issuing "clicked" on mouse up is bad :-/ -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
