giving me 4 minutes to respond, nice. I appreciate the courtesy you've shown.
the warning is absolutely necessary since the code is valid and the warning was intended for catching genuine (though obscure, since it's nearly impossible to trigger the warning on your own) programming errors: none of the warnings are such errors, but number of warnings generated will obscure worthwhile warning messages and prevent them from being seen. we have the ability to test for its existence, so it should be enabled. as for C99 mode, this also is a requirement for using dns.c, and the C99 is only required for preprocessing from what I can tell. if you like, disable dns.c on platforms that don't support C99; it's 2012 now, however, and I should think this would not be the case for any platforms we spend most of our time on. On Thu, Jun 7, 2012 at 4:39 PM, Vincent Torri <[email protected]>wrote: > done, actually > > On Thu, Jun 7, 2012 at 5:33 PM, Vincent Torri <[email protected]> > wrote: > > can you please revert that ? If not, i'll revert it > > > > Vincent > > > > On Thu, Jun 7, 2012 at 12:27 PM, Enlightenment SVN > > <[email protected]> wrote: > >> Log: > >> force c99 mode when using dns.c > >> > >> > >> Author: discomfitor > >> Date: 2012-06-07 03:27:18 -0700 (Thu, 07 Jun 2012) > >> New Revision: 71790 > >> Trac: http://trac.enlightenment.org/e/changeset/71790 > >> > >> Modified: > >> trunk/ecore/configure.ac trunk/ecore/src/lib/ecore_con/Makefile.am > >> > >> Modified: trunk/ecore/configure.ac > >> =================================================================== > >> --- trunk/ecore/configure.ac 2012-06-07 10:06:50 UTC (rev 71789) > >> +++ trunk/ecore/configure.ac 2012-06-07 10:27:18 UTC (rev 71790) > >> @@ -1527,6 +1527,10 @@ > >> fi > >> > >> AM_CONDITIONAL([HAVE_CARES], [test "x${have_cares}" = "xyes"]) > >> +if test "x${have_cares}" != "xyes" ; then > >> + C99="$ac_cv_prog_cc_c99" > >> + AC_SUBST(C99) > >> +fi > >> > >> # ecore_ipc > >> ECORE_CHECK_MODULE([ipc], [${want_ecore_ipc}], [Ipc], > [${have_ecore_con}], > >> > >> Modified: trunk/ecore/src/lib/ecore_con/Makefile.am > >> =================================================================== > >> --- trunk/ecore/src/lib/ecore_con/Makefile.am 2012-06-07 10:06:50 UTC > (rev 71789) > >> +++ trunk/ecore/src/lib/ecore_con/Makefile.am 2012-06-07 10:27:18 UTC > (rev 71790) > >> @@ -35,7 +35,7 @@ > >> libecore_con_la_SOURCES += ecore_con_ares.c > >> else > >> if HAVE_IPV6 > >> -AM_CPPFLAGS += -Wno-override-init > >> +AM_CPPFLAGS += -Wno-override-init $(C99) > >> libecore_con_la_SOURCES += ecore_con_dns.c dns.c dns.h > >> else > >> libecore_con_la_SOURCES += ecore_con_info.c > >> > >> > >> > ------------------------------------------------------------------------------ > >> Live Security Virtual Conference > >> Exclusive live event will cover all the ways today's security and > >> threat landscape has changed and how IT managers can respond. > Discussions > >> will include endpoint security, mobile security and the latest in > malware > >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > >> _______________________________________________ > >> enlightenment-svn mailing list > >> [email protected] > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
