A warning is fine, but it doesn't stop your application from crashing immediately instead of returning NULL as it should.
On Wed, Jun 13, 2012 at 11:48 AM, ChunEon Park <[email protected]> wrote: > And Actually, I already added the warnings about that. > > > 6467 * @warning We don't guarantee any proper results if you create a > Image object > 6468 * without setting the evas engine. > > of course other objects also. > > ------------------------------------ > -Regards, Hermet- > > > -----Original Message----- > From: "ChunEon Park"<hermet>@naver.com> > To: <enlightenment-devel>@lists.sourceforge.net>; <enlightenment-svn>@ > lists.sourceforge.net>; > Cc: > Sent: 2012-06-13 (수) 19:32:32 > Subject: Re: [E-devel] E SVN: discomfitor IN trunk/evas: . src/lib/canvas > > Not only image but other much functions depend on the engine now. > It's awful to check the engine for every APIs. > > How about just putting the information in doc? > > ------------------------------------ > -Regards, Hermet- > > > -----Original Message----- > From: "Enlightenment SVN"<no-reply>@enlightenment.org> > To: <enlightenment-svn>@lists.sourceforge.net>; > Cc: > Sent: 2012-06-13 (수) 17:20:28 > Subject: E SVN: discomfitor IN trunk/evas: . src/lib/canvas > > Log: > fix crash when adding an image to an engineless canvas > > > Author: discomfitor > Date: 2012-06-13 01:20:28 -0700 (Wed, 13 Jun 2012) > New Revision: 72071 > Trac: http://trac.enlightenment.org/e/changeset/72071 > > Modified: > trunk/evas/ChangeLog trunk/evas/src/lib/canvas/evas_object_image.c > > Modified: trunk/evas/ChangeLog > =================================================================== > --- trunk/evas/ChangeLog2012-06-13 08:15:28 UTC (rev 72070) > +++ trunk/evas/ChangeLog2012-06-13 08:20:28 UTC (rev 72071) > @@ -800,3 +800,8 @@ > 2012-06-12 ChunEon Park (Hermet) > > * Removed empty evas_object_map_source_set/get APIs. Will Not be > implemented. > + > +2012-06-13 Mike Blumenkrantz > + > + * Fix crash in evas_object_image_add() when called prior to > setting an engine > + for the given canvas. > > Modified: trunk/evas/src/lib/canvas/evas_object_image.c > =================================================================== > --- trunk/evas/src/lib/canvas/evas_object_image.c2012-06-13 08:15:28 UTC > (rev 72070) > +++ trunk/evas/src/lib/canvas/evas_object_image.c2012-06-13 08:20:28 UTC > (rev 72071) > @@ -177,6 +177,7 @@ > MAGIC_CHECK(e, Evas, MAGIC_EVAS); > return NULL; > MAGIC_CHECK_END(); > + EINA_SAFETY_ON_NULL_RETURN_VAL(e->engine.func, NULL); > obj = evas_object_new(e); > evas_object_image_init(obj); > evas_object_inject(obj, e); > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-svn mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
