* Gustavo Sverzut Barbieri <[email protected]> [2012-06-19 15:28:41 
-0300]:

> On Tue, Jun 19, 2012 at 3:20 PM, Enlightenment SVN
> <[email protected]> wrote:
> > Log:
> > Elm: fix the widget event callback freeing
> >
> >  Removes the event callback list within _smart_del. The current
> >  implementation does not care about the node data resulting on
> >  memory leaks.
> >
> >  Here follows the valgrind log:
> >
> >  16 bytes in 1 blocks are definitely lost in loss record 11 of 168
> >  at 0x4C29DB4: calloc (in
> >          /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
> >          by 0x522EC34: elm_widget_event_callback_add (elm_widget.c:1996)
> >          by 0x5A7AA2B: _edje_emit_handle (edje_program.c:1322)
> >          by 0x5A766B6: _edje_message_queue_process 
> > (edje_message_queue.c:764)
> >          by 0x5A76856: _edje_job (edje_message_queue.c:160)
> >          by 0x628C02A: _ecore_job_event_handler (ecore_job.c:115)
> >          by 0x6288C1F: _ecore_event_call (ecore_private.h:319)
> >          by 0x628D09B: _ecore_main_loop_iterate_internal (ecore_main.c:1814)
> >          by 0x628D566: ecore_main_loop_begin (ecore_main.c:931)
> >          by 0x4023B0: elm_main (test.c:198)
>
> I'm worried about it. The original code says it should be empty, but
> it's not. That would mean some callbacks are still pending and were
> not deleted. If that was the case, then if the callback is called it
> would access the now-deleted memory.

Don't worry. It's not a direct Evas object event callback, just a list
with event matching data. The real Evas event hooking happens on
widget_can_focus_set(), reaching that list via
elm_widget_event_propagate(). If the object dies, you won't have them
called anymore.

>
> Maybe investigate why the callbacks were not deleted?
>
> Alternatively you should check how to delete the callbacks and their data.
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --------------------------------------
> MSN: [email protected]
> Skype: gsbarbieri
> Mobile: +55 (19) 9225-2202
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
Gustavo Lima Chaves
Computer Engineer @ ProFUSION Embedded Systems

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to