On 06/21/2012 12:42 PM, Enlightenment SVN wrote: > Log: > fix pager id saving, fixes #684 and also deletes your pager configs
Seriously? Return strdup()'ed string when the return type is const char and the func previously returned a static string? I see a 100% chance of memory leak. S. > > > Author: discomfitor > Date: 2012-06-21 03:42:04 -0700 (Thu, 21 Jun 2012) > New Revision: 72586 > Trac: http://trac.enlightenment.org/e/changeset/72586 > > Modified: > trunk/e/src/modules/pager/e_mod_main.c > > Modified: trunk/e/src/modules/pager/e_mod_main.c > =================================================================== > --- trunk/e/src/modules/pager/e_mod_main.c 2012-06-21 10:23:42 UTC (rev > 72585) > +++ trunk/e/src/modules/pager/e_mod_main.c 2012-06-21 10:42:04 UTC (rev > 72586) > @@ -271,9 +271,13 @@ > } > > static const char * > -_gc_id_new(E_Gadcon_Client_Class *client_class __UNUSED__) > +_gc_id_new(E_Gadcon_Client_Class *client_class) > { > - return _gadcon_class.name; > + char buf[PATH_MAX]; > + > + snprintf(buf, sizeof(buf), "%s.%d", client_class->name, > + eina_list_count(pager_config->instances)); > + return strdup(buf); > } > > static Pager * > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
