On Mon, 02 Jul 2012 19:34:00 +0900 Minseok Kim <minseok3....@samsung.com> said:
in svn it is! thanks very much! :) > Thanks for comments. > I send modified patch. > Please review this patch. > > Thank you > > -----Original Message----- > From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] > Sent: Friday, June 29, 2012 6:37 PM > To: Enlightenment developer list > Cc: Minseok Kim > Subject: Re: [E-devel] [E-deve] [Patch] Add new apis for editable set/get in > multibuttonentry > > On Tue, 26 Jun 2012 19:07:35 +0900 Minseok Kim <minseok3....@samsung.com> > said: > > > Dear all, > > > > Typically multibuttonentry is used as a composer. > > But sometimes, Multibuttonentry can be used as a viewer. > > Currently there is no way to use multibuttonentry as non-editable viewer. > > So I added new APIs which are elm_multibuttonentry_editable_set/get(). > > If editable is true, entry in multibuttonentry is activated and user > > can compose item by pressing the return key. > > If not, entry is hidden and muttibuttonentry works as a non-editable > viewer. > > here we go: > > 1. you need: > @since 1.1 > in the dos in Elementary.h.in to let people know it was added after 1.0 2. > you should add {} around the first if block for: > if (elm_widget_focus_get(obj) || wd->focused) > if (!wd->selected_it) > elm_object_focus_set(wd->entry, EINA_TRUE); > like: > if (elm_widget_focus_get(obj) || wd->focused) > { > if (!wd->selected_it) > elm_object_focus_set(wd->entry, EINA_TRUE); > } > > otherwise ok. can you fix these and re-send? > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
