On Thu, Jul 5, 2012 at 11:13 AM, Gustavo Lima Chaves <[email protected]> wrote: > * Enlightenment SVN <[email protected]> [2012-07-03 05:09:34 -0700]: > >> Log: >> From: Kim Shinwoo <[email protected]> >> Subject: [E-devel] [Patch][elm_widget] access hook >> >> Real time setting would be necessary in case of running applications >> which >> have elm_layout or elm_widget_item. >> If the access mode does not care of this, running applications should >> restart. The attached for this. Please review the patch and give any >> feedbacks. Thanks. >> >> >> >> +2012-07-3 Shinwoo Kim (kimcinoo) >> + >> + * Add access hook to widget infra. >> + > > Who uses it? What is it meant to do? > >> >> Modified: trunk/elementary/src/lib/elm_widget.c >> =================================================================== >> --- trunk/elementary/src/lib/elm_widget.c 2012-07-03 12:07:25 UTC (rev >> 73228) >> +++ trunk/elementary/src/lib/elm_widget.c 2012-07-03 12:09:34 UTC (rev >> 73229) >> @@ -82,6 +82,7 @@ >> void (*activate)(Evas_Object *obj); >> void (*disable)(Evas_Object *obj); >> void (*theme)(Evas_Object *obj); >> + void (*access)(Evas_Object *obj, Eina_Bool is_access); > > Please, ALWAYS update the ELM_WIDGET_SMART_CLASS_INIT macro whenever > you change this struct! > >> void (*translate)(Evas_Object *obj); >> Eina_Bool (*event)(Evas_Object *obj, >> Evas_Object *source, >> @@ -1075,6 +1076,16 @@ >> } >> >> EAPI void >> +elm_widget_access_hook_set(Evas_Object *obj, >> + void (*func)(Evas_Object *obj, >> + Eina_Bool is_access)) >> +{ >> + API_ENTRY return; >> + >> + COMPAT_SMART_DATA(sd)->access = func; >> +} > > Remember, we are approaching ZERO compat widgets inside elm. No more > hooks like that, please.
I also wonder why new code would use deprecated stuff... if we're adding new, just add update code, not legacy. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
