On Sat, 7 Jul 2012 20:27:16 +0100 Michael Blumenkrantz <michael.blumenkra...@gmail.com> wrote:
> On Sat, 7 Jul 2012 12:10:51 -0700 > "Enlightenment SVN" <no-re...@enlightenment.org> wrote: > > > Log: > > Multiple improvements and some cleanup: > > > > * Switch channel/server text to use Evas textgrid instead > > of elm_entry. This is of course missing a lot of nice > > things like scrolling, selection, colors, etc. This > > is in the TODO. > > * Redesign the interface a bit. Still not looking great, but > > this is probably the next thing to work on. It's on the TODO. > > * IRC code no longer converts the utf8 to markup. It just > > passes it directly to the frontend. The frontend also > > must convert any text with markup to utf8 before sending > > to the library. > > * Removed some random printfs. Incorporating Eina log > > is in the TODO. > > * Updated TODO to reflect the current state of things. > > > > There is a lot to do so any help would be appreciated. > > Particularly I'd love some feedback on how bad the code is and ways > > it can be improved. I didn't check this code for memory leaks as > > it's not really in a daily usable state yet. > > > > > > > > Author: mekius > > Date: 2012-07-07 12:10:51 -0700 (Sat, 07 Jul 2012) > > New Revision: 73456 > > Trac: http://trac.enlightenment.org/e/changeset/73456 > > > > Modified: > > trunk/PROTO/emote/TODO trunk/PROTO/emote/src/bin/em_config.c > > trunk/PROTO/emote/src/bin/em_gui.c > > trunk/PROTO/emote/src/bin/em_gui.h trunk/PROTO/emote/src/bin/main.c > > trunk/PROTO/emote/src/lib/emote_event.c > > trunk/PROTO/emote/src/lib/emote_protocol.c > > trunk/PROTO/emote/src/lib/protocols/irc/irc.c > > trunk/PROTO/emote/src/lib/protocols/irc/irc_parse.c > > > > * any reason you're not using eina_module ? IIRC this code predated eina_module or we had reasons for not using it at the time. It's been awhile so I cannot recall. The actual exported functions for each protocol are fairly small as most of the interface is implemented using ecore events. > * I see a lot of calls to ecore_con_server_connected_get(); in > general, any time you have to call this function you're probably > doing something wrong I think this was just a safeguard to ensure the connection was still open. Is there a callback that should be used instead when the connection is lost? > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. > Discussions will include endpoint security, mobile security and the > latest in malware threats. > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ enlightenment-devel > mailing list enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
