Cedric, Gustavo and Vincent, thank you for your comments. I updated the patch according to your opinions (removed entry APIs and added 1 elm_config variable to enable or disable magnifier) I know we are in a feature freeze now but I'd like to make this entry patch be acceptable in svn when it's possible. So please review this patch when you're available and give me a feedback if there's something to be fixed.
Regards, -------------- Myungjae Lee. ------- Original Message ------- Sender : Gustavo Sverzut Barbieri<barbi...@profusion.mobi> Date : 2012-07-06 20:07 (GMT+09:00) Title : Re: [E-devel] [Patch] [Elementary] added magnifier feature to elm_entry On Friday, July 6, 2012, Cedric BAIL wrote: > Hello, > > On Fri, Jul 6, 2012 at 7:37 PM, Myung-Jae Lee > > wrote: > > I'm trying to add entry features those are useful in the mobile > envieronment such as magnifier and selection block handlers. > > Some of these might be conflicted with desktop entries' functionalities > or meaningless in the desktop entries. > > Therefore I've splitted the patches according to the functionality and > I'm sending them one after another. > > I do disagree with you. I think this kind of feature could be useful > for people with limited sightedness on desktop to. > > > The attached patch is related to the entry magnifier feature that helps > user move cursor easily in a mobile entry. > > This can be more useful with another selection mode in a edje_entry that > supports moving cursor in mouse_move. > > However as I described above, I'll send the edje_entry selection patch > (that will also include one more change in long press detection in an > elm_entry) right after this magnifier patch is accepted. > > So, please review this patch just focused on magnifier feature itself. > > > > I added next 2 APIs to enable or disable magnifier feature in an entry. > > - EAPI void elm_entry_magnifier_disabled_set(Evas_Object *obj, Eina_Bool > disabled); > > - EAPI Eina_Bool elm_entry_magnifier_disabled_get(const Evas_Object > *obj); > > Shouldn't that be part of Elementary window config ? As application > should really not care about that. Yes, and I'd say it should emit some signal or callbacks and be replaceable from outside of elm. If its possible to have the magnifier usable from other places (magnify at x,y the object o) it would be helpful as well. > > Regards, > -- > Cedric BAIL > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
elm_entry.diff
Description: Binary data
magnifier.png
Description: Binary data
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
