Am Montag, 9. Juli 2012 um 05:25 schrieb Carsten Haitzler: > On Sun, 8 Jul 2012 21:10:50 -0500 Nick Hughart <mek...@mekius.net > (mailto:mek...@mekius.net)> said: > > > On Mon, 9 Jul 2012 03:56:03 +0200 > > Leif Middelschulte <leif.middelschu...@gmail.com > > (mailto:leif.middelschu...@gmail.com)> wrote: > > > > Based on conversations in IRC, Raster has already expressed that > > support for Xresources is an unnecessary evil for Terminology. He made > > it clear that support for it would not be going into Terminology nor > > Ecore. If distributions want to patch this in, they can go ahead, but > > it's probably not making it upstream. > > > > > yup. reject. That's perfectly fine. We don't have some website or system where we provide patches for apps in our repository so I figured I'd just send it to the list so when people google for "terminology xresources background" they'll find this patch :)
Maybe we should have another keyword like [patch/optional] or alike for patches that shouldn't go upstream necessarily. > 1. you hurt terminology's wonderful display independence. it works in > framebuffer and in wayland. it probably should work on osx and windows too as > long as the libc bits are supported (pty opening and ioctl's). > > 2. xresources/defaults is ugly and almost no one uses it anymore. it's a > leftover for a lot of "old school terminal emulators" because most of these > were written in xlib/xt days where this was normal. > > 3. since we need color customisation anyway we will have to duplicate this > functionality then in another way for it to work outside of x11, so it just > discourages that work to be done. > > 4. xrdb handling is fought leaks. you open the xrm db and never close it. yay! > leak. now if u try and close/delete it.. segv! hooray!. this does not make me > a > happy bunny. > > > > > 2012/7/9 Gustavo Sverzut Barbieri <barbi...@profusion.mobi > > > (mailto:barbi...@profusion.mobi)>: > > > > On Sun, Jul 8, 2012 at 10:37 PM, Leif Middelschulte > > > > <leif.middelschu...@gmail.com (mailto:leif.middelschu...@gmail.com)> > > > > wrote: > > > > > Hey guys, > > > > > > > > > > find attached a patch for terminology based on r73450 making it use > > > > > the xresource background color if available and enabled in > > > > > Terminology's settings. > > > > > > > > > > What can be improved: > > > > > - Add xrdb abstraction to ecore_x (depends on Xlib right now) > > > > > - Make clicking the radio button immediately trigger > > > > > disabling/enabling the background color (needs restart atm) > > > > > > > > > > So, as you can see, it's not good enough for upstream yet. > > > > > > > > > > For those who don't like the shadow: Simple use the mild theme > > > > > provided with Terminology ('-t=mild' switch) > > > > > > > > > > > > > > > > > I didn't look at the patch, but I'd say: keep away from > > > > Xresources... it's ugly, legacy and confusing if you already have > > > > simple in-app configuration. > > > > > > > > > > Probably true in most cases. But sometimes people just use some > > > .Xresources file they found on the web for e.g. nice `ls` colors, etc. > > > > > > > > it's just simpler to add the color selection inside terminology. We > > > > even have a colorselector widget, it's almost zero-effort. > > > > > > > > > > You're probably right. That's the reason I didn't invest more work. > > > Actually just thought this patch might be usable for other people too > > > and doesn't necessarily have to be improved. It can stay in people's > > > local repositories if it's useful for them. Just wanted to share it. > > > > > > > > -- > > > > Gustavo Sverzut Barbieri > > > > http://profusion.mobi embedded systems > > > > -------------------------------------- > > > > MSN: barbi...@gmail.com (mailto:barbi...@gmail.com) > > > > Skype: gsbarbieri > > > > Mobile: +55 (19) 9225-2202 > > > > > > > > ------------------------------------------------------------------------------ > > > > Live Security Virtual Conference > > > > Exclusive live event will cover all the ways today's security and > > > > threat landscape has changed and how IT managers can respond. > > > > Discussions will include endpoint security, mobile security and the > > > > latest in malware threats. > > > > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > > > _______________________________________________ enlightenment-devel > > > > mailing list enlightenment-devel@lists.sourceforge.net > > > > (mailto:enlightenment-devel@lists.sourceforge.net) > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > (mailto:enlightenment-devel@lists.sourceforge.net) > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > (mailto:ras...@rasterman.com) > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > (mailto:enlightenment-devel@lists.sourceforge.net) > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
