Well, that's a different bug that was there that I missed and didn't fix, not new. :)
But yeah, I'll fix it. -- Tom. On 12/07/12 10:25, Cedric BAIL wrote: > On Thu, Jul 12, 2012 at 4:08 PM, Enlightenment SVN > <no-re...@enlightenment.org> wrote: >> Log: >> Edje text classes: Fixed issues with textblock and some inconsistency. >> >> Author: tasn >> Date: 2012-07-12 00:08:05 -0700 (Thu, 12 Jul 2012) >> New Revision: 73601 >> Trac: http://trac.enlightenment.org/e/changeset/73601 >> >> Modified: >> trunk/edje/ChangeLog trunk/edje/src/lib/edje_util.c >> >> Modified: trunk/edje/ChangeLog >> =================================================================== >> --- trunk/edje/ChangeLog 2012-07-12 07:08:00 UTC (rev 73600) >> +++ trunk/edje/ChangeLog 2012-07-12 07:08:05 UTC (rev 73601) >> @@ -518,4 +518,8 @@ >> >> * Textblock: Fixed issue with updating only the font size using text >> classes. >> + * Textblock: Fixed updating textblock text_class with >> + edje_text_class_set. >> + * Text classes: Fixed edje_text_class_set to behave like >> + edje_object_text_class_set (and as expected) wrt NULL fonts. >> >> >> Modified: trunk/edje/src/lib/edje_util.c >> =================================================================== >> --- trunk/edje/src/lib/edje_util.c 2012-07-12 07:08:00 UTC (rev 73600) >> +++ trunk/edje/src/lib/edje_util.c 2012-07-12 07:08:05 UTC (rev 73601) >> @@ -816,23 +816,20 @@ >> >> tc->font = eina_stringshare_add(font); >> tc->size = size; >> - return EINA_FALSE; >> } >> - >> - /* If the class found is the same just return */ >> - if ((tc->size == size) && (tc->font) && (!strcmp(tc->font, font))) >> - return EINA_TRUE; >> - >> - /* Update the class found */ >> - eina_stringshare_del(tc->font); >> - tc->font = eina_stringshare_add(font); >> - if (!tc->font) >> + else >> { >> - eina_hash_del(_edje_text_class_hash, text_class, tc); >> - free(tc); >> - return EINA_FALSE; >> + /* Match and the same, return */ >> + if ((tc->size == size) || >> + (tc->font == font) || >> + (tc->font && font && !strcmp(tc->font, font))) >> + return EINA_TRUE; >> + >> + /* Update the class found */ >> + eina_stringshare_del(tc->font); >> + tc->font = eina_stringshare_add(font); >> + tc->size = size; > > Better using eina_stringshare_replace, no ? > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
