On Fri, 20 Jul 2012 22:43:21 +0200 rustyBSD <rusty...@gmx.fr> said: > (re)Hi, > when copying symlinks, it creates a symlink to the > destination but with the name of the pointed file/folder. > > It causes problems, ex: we can't copy two symlinks > pointing to the same file, because they will have the > same name. > > Here is a patch which corrects this. I also found other > problems and bugs in file managing; I will look at it > tomorrow. > > ps: I don't have svn commit access.
i don't know about you.. but i'm happily copying a dir with 2 symlinks pointing to the same file. with efm. slight issue. it seems to make the file pointed to have the same perms as the symlinks. :) but if only 1 file points to it even. nb your patch also leaks memory. you don't free lnk_path or dst_dir - both of which are alloced. you recompose dst_path when task->desk.name is sufficient to use. also using ecore_readlink instead of readlink - fine, but i'm failing to see the bug you're fixing :( it does the exact same work, just using ecore calls... hmm looking at svn someone has committed half your patch with leaks fixed, but i'm failing to see the "bug fix" ? :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
