Please someone review this patch.
This fixed clouseau pane problems.

 I don't know why did someone add the flag to scroller even it seemed it 
shouldn't be there.

------------------------------------
-Regards, Hermet-
-----Original Message-----
From: "Enlightenment SVN"<no-re...@enlightenment.org> 
To: <enlightenment-...@lists.sourceforge.net>; 
Cc: 
Sent: 2012-07-24 (화) 11:35:25
Subject: E SVN: hermet IN trunk/elementary: . src/lib

Log:
elementary/scroller - Fixed scroller to not have the hold flag which causes the 
edje object up event block.
  
  Please review this patch I don't know the intention why did someone add this 
flags on mouse up in scroller.
  
  Anyhow I tested and works fine.
  
  

Author:       hermet
Date:         2012-07-23 19:35:25 -0700 (Mon, 23 Jul 2012)
New Revision: 74334
Trac:         http://trac.enlightenment.org/e/changeset/74334

Modified:
  trunk/elementary/ChangeLog trunk/elementary/src/lib/els_scroller.c 

Modified: trunk/elementary/ChangeLog
===================================================================
--- trunk/elementary/ChangeLog2012-07-24 02:16:21 UTC (rev 74333)
+++ trunk/elementary/ChangeLog2012-07-24 02:35:25 UTC (rev 74334)
@@ -336,3 +336,7 @@
 2012-07-23  Hermet (ChunEon Park)

 * fixed invalid sd memory access when delete window inlined image
+
+2012-07-24  Hermet (ChunEon Park)
+
+* fixed scroller to not have the hold flag when mouse up happened.

Modified: trunk/elementary/src/lib/els_scroller.c
===================================================================
--- trunk/elementary/src/lib/els_scroller.c2012-07-24 02:16:21 UTC (rev 74333)
+++ trunk/elementary/src/lib/els_scroller.c2012-07-24 02:35:25 UTC (rev 74334)
@@ -2162,7 +2162,6 @@
 #else
                        t = ecore_loop_time_get();
 #endif
-                       ev->event_flags = EVAS_EVENT_FLAG_ON_HOLD;
                        ax = ev->canvas.x;
                        ay = ev->canvas.y;
                        at = 0.0;
@@ -2315,10 +2314,7 @@
                   sd->down.scroll = EINA_FALSE;
                }
              if (sd->down.hold)
-               {
-                  ev->event_flags = EVAS_EVENT_FLAG_ON_HOLD;
-                  sd->down.hold = EINA_FALSE;
-               }
+               sd->down.hold = EINA_FALSE;
              sd->down.dragged_began = EINA_FALSE;
              sd->down.dir_x = EINA_FALSE;
              sd->down.dir_y = EINA_FALSE;


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to