* woohyun <woo_hyun0...@naver.com> [2012-07-25 11:56:43 +0900]: > Hello. glima :) > > I wanna get review about this commit. > Because of _elm_legacy_is returned EINA_FALSE, elm_scroller's focus_region > was not called. > Can I know the intention of "_elm_legacy_is" at this line ? > > Thanks :)
Hi, Woohyun :) This was answered after the commit itself, thanks for spotting that :) Regards, > > -----Original Message----- > From: "Enlightenment SVN"<no-re...@enlightenment.org> > To: <enlightenment-...@lists.sourceforge.net>; > Cc: > Sent: 2012-07-25 (수) 11:43:33 > Subject: E SVN: woohyun trunk/elementary/src/lib > > Log: > elementary/elm_widget : focus_region function in elm_scroller was not > executed because of _elm_legacy_is always returned EINA_FALSE. So I removed > it. > > > Author: woohyun > Date: 2012-07-24 19:43:32 -0700 (Tue, 24 Jul 2012) > New Revision: 74367 > Trac: http://trac.enlightenment.org/e/changeset/74367 > > Modified: > trunk/elementary/src/lib/elm_widget.c > > Modified: trunk/elementary/src/lib/elm_widget.c > =================================================================== > --- trunk/elementary/src/lib/elm_widget.c2012-07-25 02:39:33 UTC (rev 74366) > +++ trunk/elementary/src/lib/elm_widget.c2012-07-25 02:43:32 UTC (rev 74367) > @@ -889,7 +889,7 @@ > { > Evas_Coord px, py; > sd2 = evas_object_smart_data_get(o); > - if (_elm_legacy_is(o) && sd2->focus_region) > + if (sd2->focus_region) > { > sd2->focus_region(o, x, y, w, h); > elm_widget_focus_region_get(o, &x, &y, &w, &h); > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > -- Gustavo Lima Chaves Computer Engineer @ ProFUSION Embedded Systems ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
