On Thu, 26 Jul 2012 08:51:18 -0300 Gustavo Sverzut Barbieri <[email protected]> said:
> On Thursday, July 26, 2012, ChunEon Park wrote: > > > This will cause compatibility break. > > > > Current previous buttons in applications may not have the icon swallow > > part. > > > > > So what? The icon is hidden and it's invisible. The old theme should have > the icon as a part and it will be visible. It should not break. > > Alternatively we can part_exists() before creating the icon. But shouldn't > be required. if someone already has the theme with this back button style, then it stops being used and their app visually breaks. :) > > ------------------------------------ > > -Regards, Hermet- > > -----Original Message----- > > From: "Enlightenment SVN"<[email protected] <javascript:;>> > > To: <[email protected] <javascript:;>>; > > Cc: > > Sent: 2012-07-26 (목) 02:20:34 > > Subject: E SVN: barbieri IN trunk/elementary: data/themes/widgets src/lib > > > > Log: > > naviframe: improve default back button. > > > > back button now uses standard icon "arrow_left", and provides a "Back" > > text that should be translated with the application. > > > > Then we can define the elm/button/base/naviframe/back_btn/default as > > an alias to the default button. If a theme wants it could still > > provide an alternative button. IOW no breaks. > > > > > > > > Author: barbieri > > Date: 2012-07-25 10:20:34 -0700 (Wed, 25 Jul 2012) > > New Revision: 74399 > > Trac: http://trac.enlightenment.org/e/changeset/74399 > > > > Modified: > > trunk/elementary/data/themes/widgets/button.edc > > trunk/elementary/src/lib/elc_naviframe.c > > > > Modified: trunk/elementary/data/themes/widgets/button.edc > > =================================================================== > > --- trunk/elementary/data/themes/widgets/button.edc2012-07-25 16:35:13 UTC > > (rev 74398) > > +++ trunk/elementary/data/themes/widgets/button.edc2012-07-25 17:20:34 UTC > > (rev 74399) > > @@ -1,5 +1,6 @@ > > group { name: "elm/button/base/default"; > > alias: "elm/button/base/popup_button/default"; > > + alias: "elm/button/base/naviframe/back_btn/default"; > > images { > > image: "bt_base1.png" COMP; > > image: "bt_base2.png" COMP; > > @@ -1103,193 +1104,6 @@ > > } > > } > > } > > -group { name: "elm/button/base/naviframe/back_btn/default"; > > - images { > > - image: "bt_base1.png" COMP; > > - image: "bt_base2.png" COMP; > > - image: "bt_hilight.png" COMP; > > - image: "bt_shine.png" COMP; > > - image: "bt_glow.png" COMP; > > - image: "bt_dis_base.png" COMP; > > - image: "bt_dis_hilight.png" COMP; > > - image: "icon_left_arrow.png" COMP; > > - } > > - parts { > > - part { name: "button_image"; > > - mouse_events: 1; > > - description { state: "default" 0.0; > > - min: 12 12; > > - image { > > - normal: "bt_base2.png"; > > - border: 7 7 7 7; > > - } > > - image.middle: SOLID; > > - } > > - description { state: "clicked" 0.0; > > - inherit: "default" 0.0; > > - image.normal: "bt_base1.png"; > > - } > > - description { state: "disabled" 0.0; > > - inherit: "default" 0.0; > > - image { > > - normal: "bt_dis_base.png"; > > - border: 4 4 4 4; > > - } > > - } > > - } > > - part { name: "prev_image"; > > - type: IMAGE; > > - scale: 1; > > - description { state: "default" 0.0; > > - min: 15 15; > > - max: 15 15; > > - fixed: 1 1; > > - align: 0.5 0.5; > > - image.normal: "icon_left_arrow.png"; > > - } > > - } > > - part { name: "over1"; > > - mouse_events: 0; > > - description { state: "default" 0.0; > > - rel2.relative: 1.0 0.5; > > - image { > > - normal: "bt_hilight.png"; > > - border: 7 7 7 0; > > - } > > - } > > - description { state: "disabled" 0.0; > > - inherit: "default" 0.0; > > - image { > > - normal: "bt_dis_hilight.png"; > > - border: 4 4 4 0; > > - } > > - } > > - } > > - part { name: "over2"; > > - mouse_events: 1; > > - repeat_events: 1; > > - ignore_flags: ON_HOLD; > > - description { state: "default" 0.0; > > - image { > > - normal: "bt_shine.png"; > > - border: 7 7 7 7; > > - } > > - } > > - description { state: "disabled" 0.0;--- > > trunk/elementary/src/lib/elc_naviframe.c2012-07-25 16:35:13 UTC (rev 74398) > > +++ trunk/elementary/src/lib/elc_naviframe.c2012-07-25 17:20:34 UTC (rev > > 74399) > > @@ -614,7 +614,7 @@ > > static Evas_Object * > > _back_btn_new(Evas_Object *obj) > > { > > - Evas_Object *btn; > > + Evas_Object *btn, *ico; > > char buf[1024]; > > > > btn = elm_button_add(obj); > > @@ -625,7 +625,13 @@ > > snprintf > > (buf, sizeof(buf), "naviframe/back_btn/%s", > > elm_widget_style_get(obj)); > > elm_object_style_set(btn, buf); > > + elm_object_domain_translatable_text_set(btn, PACKAGE, N_("Back")); > > > > + ico = elm_icon_add(btn); > > + elm_icon_standard_set(ico, "arrow_left"); > > + elm_object_style_set(btn, buf); > > + elm_layout_content_set(btn, NULL, ico); > > + > > return btn; > > } > > > > > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > enlightenment-svn mailing list > > [email protected] <javascript:;> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > enlightenment-devel mailing list > > [email protected] <javascript:;> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -------------------------------------- > MSN: [email protected] > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
