Yop, On Fri, Jul 27, 2012 at 11:09 PM, Jean-Philippe André <j...@videolan.org> wrote: > Since I still had some time (not for long tho^^), I've tried to finish > fixing the spinner widget. > So, here are two patches that should do the trick. > > Firstly, in the EDC, enable catching double and triple clicks and > handle them just like any other click events. It also adjusts the size > of the entry in vertical mode (overlap with the buttons).
This one is in with a little modification, some "," did slip into your patch and I removed them. Please check if that's fine. > Secondly, the "month" spinner test is broken. I am not sure whether > the test itself is broken (step value of 0.05 for months?) or the > widget should be smarter than that. So, I chose the second approach > because I am really dumb: round up the spinning speed when the step is > too small. With a warning message. Yeah, much better behaviour. Patch is in. > Oh, and while I'm at it, I think the spinner should set its value when > it loses focus (so, I type something in the entry and then click > outside to validate). And handle mouse wheel events. Also, keyboard > Up/Down is kinda broken (both label and entry are visible). But I > prefer sending small patches for now. Agreed, agreed and agreed. And yes reviewing small patches is much more easy to handle indeed. > PS: no, I'm not really working for VLC anymore. This is just my > "open-source" email, I might use a different one in the future. But a > VLC interface in ELM would be an awesome showcase ;) Yep, I hope to see that change of email soon ! As for a VLC UI, that would be interesting :-) Thanks for the patches and have fun, -- Cedric BAIL ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
