On Wednesday, August 1, 2012, Cedric BAIL wrote: > On Wed, Aug 1, 2012 at 12:25 PM, Gustavo Sverzut Barbieri > <[email protected] <javascript:;>> wrote: > > On Tuesday, July 31, 2012, Cedric BAIL wrote: > >> On Wed, Aug 1, 2012 at 7:42 AM, Enlightenment SVN > >> <[email protected] <javascript:;> <javascript:;>> wrote: > >> > Log: > >> > fix edje error reporting for once and for all. > >> > > >> > edje error was a mess. First someone (maybe myself) added eina log, > >> > then people changed it to be a mix with printf()... then they > replaced > >> > eina_log with printf() + colors so it would be less verbose. > >> > > >> > It's fixed now! Using eina log infrastructure. > >> > > >> > If all that is wanted is specific messages for edje_cc domain, do it > >> > with a specific log print function (eina_log_print_cb_set()). I made > >> > it produce messages in the format: > >> > > >> > <levelcolor><progname>: <levelprefix><message> > >> > > >> > Where: > >> > - levelcolor is defined by eina_log (I hacked the win32 version, > >> > since no public api to resolve level to color). > >> > - levelprefix is "Error. " or "Warning. " to cope with traditional > >> > output. > >> > > >> > If it does not look as you wanted, let me know before stuffing some > >> > printf() again. > >> > > >> > Bonus point: reduced 2 global variables (progname and verbose), > >> > removed lots of code. > >> > >> This commit is really bad ! All warning displayed by edje_cc are gone > >> and you need to turn them on by using an environment variable ! That's > >> not the purpose of this warning. This warning explicitly tell the > >> developer that he did something wrong or bad in his edje file. We need > >> to always display them, that was the purpose of the previous code. > >> Please fix it correctly ! > > > -v Is all you need. If you want to have warnings on by default, I can do > > it. Should I? > > I think that edje compilation warning should be always on, they are > real mistake in the edc file.
Ok, it's simple to add, doing it tomorrow. > -- > Cedric BAIL > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] <javascript:;> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
