On Thu, 2 Aug 2012 15:26:02 -0300 Gustavo Sverzut Barbieri <[email protected]> said:
> On Thu, Aug 2, 2012 at 5:42 AM, Enlightenment SVN > <[email protected]> wrote: > > Log: > > fix interactive flip so it works again! :/ > > I can't test it right now, but based on the following comment it seems > you fixed one case and broke the other: > > > +#if 0 // this breaks manual flipping. :/ > > if (sd->state == sd->next_state) > > { > > /* it was flipped while flipping, do it again */ > > @@ -1282,7 +1287,7 @@ > > sd->state = !sd->next_state; > > return ECORE_CALLBACK_RENEW; > > } > > - > > +#endif > > > Is that right? The case where "it was flipped while flipping" is now broken? correct. SINGLE flips were broken in the manual case... and now... something badly broke map! :( its better than it was. if u flip while flipping u just restart the current flip anim. not as bad as it was anyway. > Also, since you're fixing it and I've complained already about the > mess, what about having clearly separate cases for manual (page) and > automatic flip modes? It's an impossible-to-understand mess at the > moment :-/ they are done that way because when dealing with manual flip, we don't just move from 0.0 to 1.0 - we have to maintain x and y coords thanks to page flip. also have to handle "revert flip" - ie go back to starting point without actually flipping to the next page etc. i'm not refactoring that code - it works. there's a long list of bugs elsewhere in elm and some even very core ones in terms of child/content handling i think as a result of the infra changes. > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -------------------------------------- > MSN: [email protected] > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
