On 08/10/2012 03:25 AM, wuzhiwen wrote: > > >> -----Original Message----- >> From: Gustavo Sverzut Barbieri [mailto:barbi...@profusion.mobi] >> Sent: Thursday, August 09, 2012 8:53 PM >> To: Enlightenment developer list >> Cc: eduardo.de.barros.l...@intel.com >> Subject: Re: [E-devel] [PATCH] evas: hide the evas object after it's smart > object >> deleted. >> >> On Thursday, August 9, 2012, Alex Wu wrote: >> >>> Hi, >>> This patch fix the bug http://trac.enlightenment.org/e/ticket/1308 >>> >>> The root cause of this bug is that when closing the window, the glview >>> widget need to invoke eng_gl_make_current() before calling it's >>> del_func. In eng_gl_make_current(), the re->win->egl_display make the >>> segfualt. It is because re->win has been nullized by >>> evas_object_hide()<--evas_object_del()<--evas_object_unref()<-- >>> _elm_win_frame_cb_close() which is triggered by clicking the "close" >>> button. >>> >>> I think it is resonable to destroy the re->win of a elm_win after all >>> smart data deleted. >> >> >> Although the patch does not look problematic per se, it fixes an egl bug in > a >> generic code? That do not seem right. Why don't you hande this condition in > egl >> engine? >> >> > I think this issue is not only for engine using egl, but for all the cases > using re->win after it is hid. >
For once I would agree with Gustavo on this one. I do not see this problem when using the opengl_x11 engine which makes me think that it is indeed engine specific and that the patch would need to be changed for the specific engine, not in a generic way. dh >> >>> >>> Patch attached. >>> >>> >>> >> >> -- >> Gustavo Sverzut Barbieri >> http://profusion.mobi embedded systems >> -------------------------------------- >> MSN: barbi...@gmail.com >> Skype: gsbarbieri >> Mobile: +55 (19) 9225-2202 >> --------------------------------------------------------------------------- ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
