I think there is still a logic flaw in the first abort condition (it's the one my team has run up against, unexpectedly). That is, if the first conditional is true, "src" could be NULL... in that case, it should not abort. See http://trac.enlightenment.org/e/ticket/1323 for a valid use case that hits this condition.
Perhaps some inlined documentation about the reason behind the aborts will prevent others from wanting to rip them out. U. Artie >-----Original Message----- >From: Michael Blumenkrantz [mailto:[email protected]] >Sent: Friday, August 17, 2012 4:41 AM >To: Enlightenment developer list >Subject: Re: [E-devel] E SVN: discomfitor trunk/evas/src/lib/canvas > >actually I do know the reason, but it's something you should talk to cedric >about. they should not have been removed. > >On Fri, Aug 17, 2012 at 12:23 PM, ChunEon Park <[email protected]> wrote: > >> You don't know the reason actually. >> >> If we all forgot this fact then these aborts will be gone along with new >> release. >> >> Let Cedric put them again when he needs. >> >> ------------------------------------ >> -Regards, Hermet- >> >> -----Original Message----- >> From: "Michael Blumenkrantz"<[email protected]> >> To: "Enlightenment developer list"< >> [email protected]>; >> Cc: >> Sent: 2012-08-17 (금) 19:46:31 >> Subject: Re: [E-devel] E SVN: discomfitor trunk/evas/src/lib/canvas >> >> talk to cedric, this was important. >> >> On Fri, Aug 17, 2012 at 11:43 AM, ChunEon Park <hermet>@naver.com> >wrote: >> >> > Don't cause abort in lib. >> > It's enough in warning with prints. >> > >> > If you need then use the gdb or keep the abort in your local. >> > >> > >> > ------------------------------------ >> > -Regards, Hermet- >> > -----Original Message----- >> > From: "Michael Blumenkrantz"<michael.blumenkrantz>@gmail.com> >> > To: "Enlightenment developer list"< >> > [email protected]>; >> > Cc: >> > Sent: 2012-08-17 (금) 18:57:27 >> > Subject: Re: [E-devel] E SVN: discomfitor trunk/evas/src/lib/canvas >> > >> > obviously a failsafe in case abort fails >> > >> > On Fri, Aug 17, 2012 at 10:54 AM, Vincent Torri <vincent.torri>@ >> gmail.com >> > >wrote: >> > >> > > what is the interest of the returns if you abort ? >> > > >> > > On Fri, Aug 17, 2012 at 11:49 AM, Enlightenment SVN >> > > <no-reply>@enlightenment.org> wrote: >> > > > Log: >> > > > put aborts back, they were added for a reason. >> > > > >> > > > >> > > > Author: discomfitor >> > > > Date: 2012-08-17 02:49:52 -0700 (Fri, 17 Aug 2012) >> > > > New Revision: 75379 >> > > > Trac: http://trac.enlightenment.org/e/changeset/75379 >> > > > >> > > > Modified: >> > > > trunk/evas/src/lib/canvas/evas_object_image.c >> > > > >> > > > Modified: trunk/evas/src/lib/canvas/evas_object_image.c >> > > > >=========================================================== >======== >> > > > --- trunk/evas/src/lib/canvas/evas_object_image.c 2012-08-17 >> > > 09:47:49 UTC (rev 75378) >> > > > +++ trunk/evas/src/lib/canvas/evas_object_image.c 2012-08-17 >> > > 09:49:52 UTC (rev 75379) >> > > > @@ -450,6 +450,7 @@ >> > > > if (obj->delete_me) >> > > > { >> > > > CRIT("Setting deleted object %p as image source %p", src, >> > obj); >> > > > + abort(); >> > > > return EINA_FALSE; >> > > > } >> > > > if (src) >> > > > @@ -457,22 +458,26 @@ >> > > > if (src->delete_me) >> > > > { >> > > > CRIT("Setting object %p to deleted image source %p", >> src, >> > > obj); >> > > > + abort(); >> > > > return EINA_FALSE; >> > > > } >> > > > if (!src->layer) >> > > > { >> > > > CRIT("No evas surface associated with source object >> > (%p)", >> > > obj); >> > > > + abort(); >> > > > return EINA_FALSE; >> > > > } >> > > > if ((obj->layer && src->layer) && >> > > > (obj->layer->evas != src->layer->evas)) >> > > > { >> > > > CRIT("Setting object %p from Evas (%p) from another >> Evas >> > > (%p)", src, src->layer->evas, obj->layer->evas); >> > > > + abort(); >> > > > return EINA_FALSE; >> > > > } >> > > > if (src == obj) >> > > > { >> > > > CRIT("Setting object %p as a source for itself", obj); >> > > > + abort(); >> > > > return EINA_FALSE; >> > > > } >> > > > } >> > > > >> > > > >> > > > >> > > >> > >> ------------------------------------------------------------------------------ >> > > > Live Security Virtual Conference >> > > > Exclusive live event will cover all the ways today's security and >> > > > threat landscape has changed and how IT managers can respond. >> > Discussions >> > > > will include endpoint security, mobile security and the latest in >> > malware >> > > > threats. >http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> > > > _______________________________________________ >> > > > enlightenment-svn mailing list >> > > > [email protected] >> > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >> > > >> > > >> > > >> > >> ------------------------------------------------------------------------------ >> > > Live Security Virtual Conference >> > > Exclusive live event will cover all the ways today's security and >> > > threat landscape has changed and how IT managers can respond. >> Discussions >> > > will include endpoint security, mobile security and the latest in >> malware >> > > threats. >http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> > > _______________________________________________ >> > > enlightenment-devel mailing list >> > > [email protected] >> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > >> > >> > >> ------------------------------------------------------------------------------ >> > Live Security Virtual Conference >> > Exclusive live event will cover all the ways today's security and >> > threat landscape has changed and how IT managers can respond. >Discussions >> > will include endpoint security, mobile security and the latest in malware >> > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> > _______________________________________________ >> > enlightenment-devel mailing list >> > [email protected] >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> > >> ------------------------------------------------------------------------------ >> > Live Security Virtual Conference >> > Exclusive live event will cover all the ways today's security and >> > threat landscape has changed and how IT managers can respond. >Discussions >> > will include endpoint security, mobile security and the latest in malware >> > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> > _______________________________________________ >> > enlightenment-devel mailing list >> > [email protected] >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. >Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. >Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >------------------------------------------------------------------------------ >Live Security Virtual Conference >Exclusive live event will cover all the ways today's security and >threat landscape has changed and how IT managers can respond. Discussions >will include endpoint security, mobile security and the latest in malware >threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >_______________________________________________ >enlightenment-devel mailing list >[email protected] >https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
