On Mon, Aug 20, 2012 at 3:36 PM, Enlightenment SVN <[email protected]> wrote: > Log: > Eio: fix possible mem leak
NO ! NO ! NO ! That's at least the second time this code full a static analyzer. Ecore_Thread will always call the cancel callback that will call free appropriately. No static analyzer can understand that at this point. Going to revert and may add a comment to prevent this kind of patch to come in again. > Author: caro > Date: 2012-08-19 23:36:55 -0700 (Sun, 19 Aug 2012) > New Revision: 75445 > Trac: http://trac.enlightenment.org/e/changeset/75445 > > Modified: > trunk/eio/src/lib/eio_single.c > > Modified: trunk/eio/src/lib/eio_single.c > =================================================================== > --- trunk/eio/src/lib/eio_single.c 2012-08-20 06:35:03 UTC (rev 75444) > +++ trunk/eio/src/lib/eio_single.c 2012-08-20 06:36:55 UTC (rev 75445) > @@ -421,7 +421,10 @@ > _eio_file_stat, > _eio_file_stat_done, > _eio_file_stat_error)) > - return NULL; > + { > + free(s); > + return NULL; > + } > > return &s->common; > } > @@ -482,7 +485,10 @@ > _eio_file_unlink, > _eio_file_unlink_done, > _eio_file_unlink_error)) > - return NULL; > + { > + free(l); > + return NULL; > + } > > return &l->common; > } > @@ -512,7 +518,10 @@ > _eio_file_mkdir, > _eio_file_mkdir_done, > _eio_file_mkdir_error)) > - return NULL; > + { > + free(r); > + return NULL; > + } > > return &r->common; > } > @@ -542,7 +551,10 @@ > _eio_file_chmod, > _eio_file_mkdir_done, > _eio_file_mkdir_error)) > - return NULL; > + { > + free(r); > + return NULL; > + } > > return &r->common; > } > @@ -574,7 +586,10 @@ > _eio_file_chown, > _eio_file_chown_done, > _eio_file_chown_error)) > - return NULL; > + { > + free(c); > + return NULL; > + } > > return &c->common; > } > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-svn mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > -- Cedric BAIL ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
