On Tue, 21 Aug 2012 10:58:16 +0000 (GMT) Doyoun Kang <[email protected]> said:
> Yes. I know that the app itself sets the indicator state. However, there is a > case that the app itself sets the indicator state USING > ecore_x_e_illume_indicator_state_set() NOT USING elm_win_indicator_mode_set > (). In this case, the indmode value in Elm_Win is not changed... As you know, > there is a library called UG in TIZEN. It uses > ecore_x_e_illume_indicator_state_set() only. That's why i added this. ok.. where do i start. 1. UG. don't get me started on that. this is not a reason to put this in. it's actually an instant reason to be suspicious of it. :) 2. UG is going PAST elm's back and finding the x window id and playing with it DIRECTLy instead of going THROUGH elm's api. that's a bug in UG. use the window handle (elm win object) and use elm's api's for it. going behind eom's back here is poor and not something to be worked around in elm. so going to have to reject here and push it back to "fix UG". :) > ------- Original Message ------- > Sender : Carsten Haitzler<[email protected]> > Date : 2012-08-21 18:02 (GMT+09:00) > Title : Re: [E-devel] [Patch] Add x property change callback in elm_win.c > > On Tue, 21 Aug 2012 01:33:04 +0000 (GMT) Doyoun Kang > said: > > ok - got an issue here - so you're tracking the indicator state property... > but the app itself is the one setting this (wm should only be reading it). who > outside of the app itself is changing/setting it? this shouldnt be needed... ? > > > Dear all. > > > > I added an event handler for ECORE_X_EVENT_WINDOW_PROPERTY in elm_win.c. > > If an user change the ECORE_X_ATOM_E_ILLUME_INDICATOR_STATE using > > ecore_x_e_illume_indicator_state_set() not using elm_win_indicator_mode_set > > (), the elm doesn't care of it. So, I added the > > ECORE_X_EVENT_WINDOW_PROPERTY callback which handles the > > ECORE_X_ATOM_E_ILLUME_INDICATOR_STATE atom. And this is available when the > > HAVE_ELEMENTARY_X is defined only. (This patch code is added in #ifdef > > HAVE_ELEMENTARY_X~ #endif) > > > > Thanks. > > -- > > Doyoun Kang > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
