Hello Michal, On Thu, Aug 23, 2012 at 7:17 AM, Michal Jagiello <m.jagie...@samsung.com>wrote:
> Hello, > > I found some errors in Ethumb module. > > - ehumb_calculate_fill function > > no check if the 'ih' argument is equal to zero. If it is equal to > zero there is a division by zero, > > - ethumb_calculate_fill_from_ratio > > no check if the Ethumb object is NULL, what can cause segmentation > fault, > > - ethumb_calculate_aspect > > no check if the 'ih' argument is equal to zero. If it is equal to > zero there is a division by zero, > > - ethumb_calculate_aspect_from_ratio > > no check if the Ethumb object is NULL, what can cause segmentation > fault, > > - ethumb_image_save > > no check if the Ethumb object is NULL, what can cause segmentation > fault, > Yes, until here the things that you pointed out make total sense. Would you provide a patch for them, or you wait for us to fix it? > - ethumb_plugin_image_resize > > function always returns EINA_TRUE, > Yes, this function was written with the possibility of failure in mind, but nothing inside it right now can fail (or at least reports failure) that could make it return EINA_FALSE. Maybe the only thing would be, as you pointed on other functions, that the Ethumb object should be checked for NULL, and return EINA_FALSE in that case. > - no documentation for Ethumb module. > Agreed, that's something that we miss on it. However, the ethumb library itself is not meant to be used by client applications, but the Ethum_Client one should be used. It's an asynchronous version of the first one, which requests thumbnails to a server, that processes these requests and answer them with the path to the generated thumbnail. All is done through dbus. Look at the client documentation, some part of its API is covered. Regards, -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
