Oops this was already committed by jypark.
It should be fixed.
Daniel Juyung Seo (SeoZ)
On Mon, Sep 3, 2012 at 2:53 PM, Daniel Juyung Seo <seojuyu...@gmail.com> wrote:
> Yeah emitting error/critical/warning messages sounds right here :)
> Still we need to handle this situation without crashing.
>
> Daniel Juyung Seo (SeoZ)
>
> On Mon, Sep 3, 2012 at 2:43 PM, Cedric BAIL <cedric.b...@free.fr> wrote:
>> On Mon, Sep 3, 2012 at 2:19 PM, Sungho Kwak <sungho....@gmail.com> wrote:
>>> Hi, my name is Sungho Kwak.
>>>
>>> I found that some functions in ecore_evas_buffer.c need NULL checks.
>>> I added check routines in "ecore_evas_buffer_pixels_get"
>>> , "ecore_evas_object_image_new".
>>>
>>> 654 EAPI const void *
>>> 655 ecore_evas_buffer_pixels_get(Ecore_Evas *ee)
>>> 656 {
>>> 657 #ifdef BUILD_ECORE_EVAS_SOFTWARE_BUFFER
>>> *658 if(!ee) return NULL;*
>>> 659 _ecore_evas_buffer_render(ee);
>>> 660 return ee->engine.buffer.pixels;
>>> 661 #else
>>> 662 return NULL;
>>> 663 #endif
>>> 664 }
>>>
>>> Please review is there any problem.
>>
>> NULL doesn't make any sense. It's more an application problem in that
>> case, better at least emit a critical warning here.
>> --
>> Cedric BAIL
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
