No worries. It's not a major infraction: E_Border *bd = e_border_focused_get(); Typically, we do not do this in E17 as it has the tendency to disguise unused variables. You could declare and assign you're variable like that, but if the variable is never used again in the code, then the compiler will not pick it up as being Unused. Which has an inadvertent side effect of the variable staying there in the code, never being used because people forget to remove them (or one of a hundred other various reasons). A typical (and better) approach is something like this: E_Border *bd; If (!(bd = e_border_focused_get())) return; Cheers, dh -----Original Message----- From: Kim Shinwoo [mailto:kimcinoo....@gmail.com] Sent: 03 September 2012 10:26 To: Enlightenment developer list Subject: Re: [E-devel] [patch][access] add atoms for action up, down
argh.. omg. i did it again? sorry for disturbing you. 2012/9/3 Chris Michael <cp.mich...@samsung.com> > Functionally, the e_module patch looks ok too. Doesn't keep to E > formatting, but it's a minor infraction ;) dh > > -----Original Message----- > From: Kim Shinwoo [mailto:kimcinoo....@gmail.com] > Sent: 03 September 2012 09:34 > To: Enlightenment developer list > Subject: [E-devel] [patch][access] add atoms for action up, down > > dear all, hello > > I have attached three patches. > > (1st) the ecore_x.access.atom.diff has newly added atoms which names > are ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_UP, > ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_DOWN. > these atoms will be used to scroll(or slide) up or down. moreover it > would be used for item traversal (?) of list like widget which has its > own widget item. > > (2nd) the e.module.access.atom.diff sends a client message with these > atoms when the mouse wheel event occurs. > > (3rd) and the elementary.win.access.atom.diff gets these atoms and do > something which will be defined soon. > this patch needs the 1st mail of the September in our mail archive ( > http://sourceforge.net/mailarchive/message.php?msg_id=29750697) > > yeah that's it, then.. please review the patch and give feedback. thanks. > > cordially, > shinwoo kim. > > > > ---------------------------------------------------------------------- > -------- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. > Discussions will include endpoint security, mobile security and the > latest in malware threats. > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ---------------------------------------------------------------------------- -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
