On Mon, 3 Sep 2012 15:04:12 +0200 Vincent Torri <vincent.to...@gmail.com> said:

> i would have used configure to check ecore_x version

insanely more complicated than a #if. u have to do the configure check then
define something and still end up with a #ifdef. the efl headers have these
version defines for exactly this reason - to avoid needing specialized
configure checks. it's much less work for everyone.

> Vincent
> 
> On Mon, Sep 3, 2012 at 2:57 PM, Daniel Juyung Seo <seojuyu...@gmail.com>
> wrote:
> > Why do we need this kind of #if?
> >
> > Daniel Juyung Seo (SeoZ)
> > On Sep 3, 2012 6:43 PM, "Enlightenment SVN" <no-re...@enlightenment.org>
> > wrote:
> >
> >> Log:
> >> add access patch from shinoo - and only on 1.8 ecore.
> >>
> >>
> >>
> >> Author:       raster
> >> Date:         2012-09-03 02:42:52 -0700 (Mon, 03 Sep 2012)
> >> New Revision: 75991
> >> Trac:         http://trac.enlightenment.org/e/changeset/75991
> >>
> >> Modified:
> >>   trunk/e/src/modules/access/e_mod_main.c
> >>
> >> Modified: trunk/e/src/modules/access/e_mod_main.c
> >> ===================================================================
> >> --- trunk/e/src/modules/access/e_mod_main.c     2012-09-03 09:42:18 UTC
> >> (rev 75990)
> >> +++ trunk/e/src/modules/access/e_mod_main.c     2012-09-03 09:42:52 UTC
> >> (rev 75991)
> >> @@ -343,7 +343,27 @@
> >>  static void
> >>  _mouse_wheel(Cover *cov __UNUSED__, Ecore_Event_Mouse_Wheel *ev
> >> __UNUSED__)
> >>  {
> >> -   // XXX: fake wheel?
> >> +   E_Border *bd = e_border_focused_get();
> >> +   if (!bd) return;
> >> +
> >> +   if (ev->z == -1) // up
> >> +     {
> >> +        printf("wheel up\n");
> >> +#if ECORE_VERSION_MAJOR >= 1
> >> +# if ECORE_VERSION_MINOR >= 8
> >> +        ecore_x_e_illume_access_action_up_send(bd->client.win);
> >> +# endif
> >> +#endif
> >> +     }
> >> +   else if (ev->z == 1) // down
> >> +     {
> >> +        printf("wheel down\n");
> >> +#if ECORE_VERSION_MAJOR >= 1
> >> +# if ECORE_VERSION_MINOR >= 8
> >> +        ecore_x_e_illume_access_action_down_send(bd->client.win);
> >> +# endif
> >> +#endif
> >> +     }
> >>  }
> >>
> >>  static Eina_Bool
> >>
> >>
> >>
> >> ------------------------------------------------------------------------------
> >> Live Security Virtual Conference
> >> Exclusive live event will cover all the ways today's security and
> >> threat landscape has changed and how IT managers can respond. Discussions
> >> will include endpoint security, mobile security and the latest in malware
> >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >> _______________________________________________
> >> enlightenment-svn mailing list
> >> enlightenment-...@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >>
> > ------------------------------------------------------------------------------
> > Live Security Virtual Conference
> > Exclusive live event will cover all the ways today's security and
> > threat landscape has changed and how IT managers can respond. Discussions
> > will include endpoint security, mobile security and the latest in malware
> > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> > _______________________________________________
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to