On 03/09/2012 07:03 PM, Rafael Antognolli wrote: > Hey devilhorns, > > Didn't you agree that the framespace stuff should be outside of Evas, > and just inside Elementary? I remember that last week you talked on > irc about having a patch available for that, so I can only understand > that you and Gustavo are not discussing about the same thing.
Yea, that was my stance originally...or rather, that was my preference... Except that it cannot be done only inside Elementary. In an ideal world yes, but what happens if someone creates an application which does not use Elementary ? Just uses a bare ecore_evas.. then their objects would not be drawing correctly (read: the could potentially be drawn below the frame). So, in order to support older applications (or applications made using Base EFL, not Elm), we have to handle it in Evas. dh > > And I also agree that all of this should go outside of Evas, handled > only by elm_win. > > On Mon, Sep 3, 2012 at 2:21 PM, Christopher Michael > <cpmicha...@comcast.net> wrote: >> Well if u r fishing for an argument (which i suspect is the case) then u are >> out of luck. I refuse to get sucked into this debate. Take it up with the >> wayland people who made it so that all client apps in wayland must draw >> their own borders. >> >> dh >> >> -- >> Sent from my Android phone with K-9 Mail. Please excuse my brevity. >> >> Gustavo Sverzut Barbieri <barbi...@profusion.mobi> wrote: >> >> Seriously, all this frame space thing feels out if place. >> >> Realistically speaking, anything but elementary should manage it. The code >> is simplified as the only place would have to do with it is elm_win and 99% >> of the cases it's automatically fixed by getting "elm_win_resize_object_add" >> right. >> >> I'm against this frame space since the first version, see my comment >> comparing that to EWS. Everyday I see more and more commits like this one >> that makes my original complaints being right >> >> --Gustavo >> >> Sent from my iPhone >> >> On 03/09/2012, at 06:41, "Enlightenment SVN" <no-re...@enlightenment.org> >> wrote: >> >>> Log: >>> Evas: When doing a move or geometry_get, we need to make sure that we >>> don't try to do these on the framespace clip object. Also, since we >>> need the evas to get the framespace clip object, just directly use the >>> framespace values from the canvas, rather than function call to get >>> those values. >>> >>> >>> >>> Author: devilhorns >>> Date: 2012-09-03 02:41:01 -0700 (Mon, 03 Sep 2012) >>> New Revision: 75989 >>> Trac: http://trac.enlightenment.org/e/changeset/75989 >>> >>> Modified: >>> trunk/evas/src/lib/canvas/evas_object_main.c >>> >>> Modified: trunk/evas/src/lib/canvas/evas_object_main.c >>> _____________________________________________ >> >>> --- trunk/evas/src/lib/canvas/evas_object_main.c 2012-09-03 09:39:30 UTC >>> (rev 75988) >>> +++ trunk/evas/src/lib/canvas/evas_object_main.c 2012-09-03 09:41:01 UTC >>> (rev 75989) >>> @@ -590,6 +590,7 @@ >>> EAPI void >>> evas_object_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y) >>> { >>> + Evas *evas; >>> int is, was = 0, pass = 0, freeze = 0; >>> int nx = 0, ny = 0; >>> >>> @@ -601,16 +602,14 @@ >>> nx = x; >>> ny = y; >>> >>> - if (!obj->is_frame) >>> + evas = obj->layer->evas; >>> + >>> + if ((!obj->is_frame) && (obj != evas->framespace.clip)) >>> { >>> if ((!obj->smart.parent) && (obj->smart.smart)) >>> { >>> - int fx, fy; >>> - >>> - evas_output_framespace_get(obj->layer->evas, >>> - &fx, &fy, NULL, NULL); >>> - nx += fx; >>> - ny += fy; >>> + nx += evas->framespace.x; >>> + ny += evas->framespace.y; >>> } >>> } >>> >>> @@ -749,6 +748,7 @@ >>> EAPI void >>> evas_object_geometry_get(const Evas_Object *obj, Evas_Coord *x, Evas_Coord >>> *y, Evas_Coord *w, Evas_Coord *h) >>> { >>> + Evas *evas; >>> int nx = 0, ny = 0; >>> >>> MAGIC_CHECK(obj, Evas_Object, MAGIC_OBJ); >>> @@ -764,16 +764,14 @@ >>> nx = obj->cur.geometry.x; >>> ny = obj->cur.geometry.y; >>> >>> - if (!obj->is_frame) >>> + evas = obj->layer->evas; >>> + >>> + if ((!obj->is_frame) && (obj != evas->framespace.clip)) >>> { >>> if ((!obj->smart.parent) && (obj->smart.smart)) >>> { >>> - int fx, fy; >>> - >>> - evas_output_framespace_get(obj->layer->evas, >>> - &fx, &fy, NULL, NULL); >>> - if (nx > 0) nx -= fx; >>> - if (ny > 0) ny -= fy; >>> + if (nx > 0) nx -= evas->framespace.x; >>> + if (ny > 0) ny -= evas->framespace.y; >>> } >>> } >>> >>> >>> ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
