Good review from glima. Thanks. Daniel Juyung Seo (SeoZ)
On Mon, Sep 3, 2012 at 10:53 PM, Tom Hacohen <tom.haco...@samsung.com> wrote: > I completely agree. Daniel caught me in a moment of weakness and tricked > me into committing this. > > I'm reverting it now. > > -- > Tom. > > On 03/09/12 16:48, Gustavo Lima Chaves wrote: >> * Enlightenment SVN <no-re...@enlightenment.org> [2012-09-03 04:14:17 -0700]: >> >>> Log: >>> Elm layout: Fix segfault in some cases. >>> >>> Apparently this fixes stuff for Daniel Zaoui with some more complicated >>> cases. >>> >>> Author: tasn >>> Date: 2012-09-03 04:14:17 -0700 (Mon, 03 Sep 2012) >>> New Revision: 76000 >>> Trac: http://trac.enlightenment.org/e/changeset/76000 >>> >>> Modified: >>> trunk/elementary/src/lib/elm_layout.c >>> >>> Modified: trunk/elementary/src/lib/elm_layout.c >>> =================================================================== >>> --- trunk/elementary/src/lib/elm_layout.c 2012-09-03 10:59:48 UTC (rev >>> 75999) >>> +++ trunk/elementary/src/lib/elm_layout.c 2012-09-03 11:14:17 UTC (rev >>> 76000) >>> @@ -70,7 +70,7 @@ >>> { >>> ELM_LAYOUT_DATA_GET(obj, sd); >>> >>> - if (sd->needs_size_calc) return; >>> + if (!sd || sd->needs_size_calc) return; >>> sd->needs_size_calc = EINA_TRUE; >>> >>> evas_object_smart_changed(obj); >>> @@ -83,7 +83,7 @@ >>> void *event_info __UNUSED__) >>> { >>> ELM_LAYOUT_DATA_GET(data, sd); >>> - if (ELM_WIDGET_DATA(sd)->frozen) return; >>> + if (!sd || ELM_WIDGET_DATA(sd)->frozen) return; >>> ELM_LAYOUT_CLASS(ELM_WIDGET_DATA(sd)->api)->sizing_eval(data); >>> } >> >> Bad, bad. Hiding bigger bugs, for sure. >> >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> Live Security Virtual Conference >>> Exclusive live event will cover all the ways today's security and >>> threat landscape has changed and how IT managers can respond. Discussions >>> will include endpoint security, mobile security and the latest in malware >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>> _______________________________________________ >>> enlightenment-svn mailing list >>> enlightenment-...@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >> >> -- >> Gustavo Lima Chaves >> Computer Engineer @ ProFUSION Embedded Systems >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
