On Mon, Sep 3, 2012 at 7:06 AM, Tom Hacohen <tom.haco...@samsung.com> wrote: > Funny you announce it on the same week people are flaming about > ABI-compat in Linux. :)
breaking ABI of unreleased sw is allowed ;-) > > -- > Tom. > > On 03/09/12 12:08, Michael Blumenkrantz wrote: >> this commit flips the parameter order for the "ok" callback in >> e_entry_dialog_show() to be consistent with every other callback in efl. if >> you have a module that is not in svn which uses this function, you MUST >> adapt to this change or your module will crash. >> >> On Mon, Sep 3, 2012 at 10:06 AM, Enlightenment SVN < >> no-re...@enlightenment.org> wrote: >> >>> Log: >>> another change I've been wanting to make for a long time: e_entry_dialog >>> now has the data param first >>> >>> >>> Author: discomfitor >>> Date: 2012-09-03 02:06:10 -0700 (Mon, 03 Sep 2012) >>> New Revision: 75983 >>> Trac: http://trac.enlightenment.org/e/changeset/75983 >>> >>> Modified: >>> trunk/e/src/bin/e_entry_dialog.c trunk/e/src/bin/e_entry_dialog.h >>> trunk/e/src/bin/e_fm.c trunk/e/src/bin/e_shelf.c >>> trunk/e/src/modules/conf_dialogs/e_int_config_profiles.c >>> trunk/e/src/modules/conf_shelves/e_int_config_shelf.c >>> trunk/e/src/modules/ibar/e_mod_config.c >>> trunk/e/src/modules/quickaccess/e_mod_config.c >>> >>> Modified: trunk/e/src/bin/e_entry_dialog.c >>> =================================================================== >>> --- trunk/e/src/bin/e_entry_dialog.c 2012-09-03 09:01:21 UTC (rev 75982) >>> +++ trunk/e/src/bin/e_entry_dialog.c 2012-09-03 09:06:10 UTC (rev 75983) >>> @@ -13,7 +13,7 @@ >>> e_entry_dialog_show(const char *title, const char *icon, const char *text, >>> const char *initial_text, >>> const char *button_text, const char *button2_text, >>> - void (*ok_func)(char *text, void *data), >>> + void (*ok_func)(void *data, char *text), >>> void (*cancel_func)(void *data), void *data) >>> { >>> E_Entry_Dialog *ed; >>> @@ -94,7 +94,7 @@ >>> >>> ed = data; >>> e_object_ref(E_OBJECT(ed)); >>> - if (ed->ok.func) ed->ok.func(ed->text, ed->ok.data); >>> + if (ed->ok.func) ed->ok.func(ed->ok.data, ed->text); >>> e_object_del(E_OBJECT(ed)); >>> e_object_unref(E_OBJECT(ed)); >>> } >>> >>> Modified: trunk/e/src/bin/e_entry_dialog.h >>> =================================================================== >>> --- trunk/e/src/bin/e_entry_dialog.h 2012-09-03 09:01:21 UTC (rev 75982) >>> +++ trunk/e/src/bin/e_entry_dialog.h 2012-09-03 09:06:10 UTC (rev 75983) >>> @@ -16,7 +16,7 @@ >>> Evas_Object *entry; >>> char *text; >>> struct { >>> - void (*func) (char *text, void *data); >>> + void (*func) (void *data, char *text); >>> void *data; >>> } ok; >>> struct { >>> @@ -31,7 +31,7 @@ >>> const char *initial_text, >>> const char *button_text, >>> const char *button2_text, >>> - void (*ok_func) (char *text, void >>> *data), >>> + void (*ok_func) (void *data, char >>> *text), >>> void (*cancel_func) (void *data), >>> void *data); >>> >>> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
