On Thu, 19 Jul 2012 09:58:38 +0000 (GMT) Myung-Jae Lee <mjae....@samsung.com> said:
this patch haveth bugs... what if en->region_vp is NULL? :) for starters. secondly the patch is reversed (-'s not +'s) and third.. the elm_entry part no longer applies after the entry internal code changes. what i have done right now is manually read the patch and re-write the code based on the patch and the current entry code. it compiles cleanly and i think i got it right, but edje side has bugs. :) > Dear all, > > This is the extension patch for the previous 'selection handler' in entry. > > Selection handlers will be displayed if they are inside the entry viewport or > will be hidden. Elm_entry gets the viewport region from the geometry of its > parents' scrollers and pass the information to edje_entry. > > Because this patch is based on the previous selection handler patch, apply > the previous one ([E-devel] [Patch] [Ejde, Elementary] added selection > handler feature to entry) first and this later. > > Please review this patch and feel free to give me feedbacks when you have > questions. > > Regards, > -------------- > Myungjae Lee -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
