On Mon, 23 Jul 2012 06:35:53 +0000 (GMT) Myung-Jae Lee <[email protected]>
said:
and of course this patch conflicts with the previous patch.. once i fixed the
segfaults. :) context problems. in fact it is beginning to become illogical.
if (eina_rectangle_is_empty(en->region_vp))
{
if ((en->region_vp->x == -1) && (en->region_vp->y
== -1))
- edje_object_signal_emit(en->handler_start,
"edje,handler,show", "edje");
+ {
+ if (!eina_rectangle_is_empty(en->region_ly) &&
+ ((ny + hh) > (en->region_ly->y +
en->region_ly->h)))
+ edje_object_signal_emit(en->handler_start,
"edje,handler,show,top", "edje");
+ else
+ edje_object_signal_emit(en->handler_start,
"edje,handler,show,bottom", "edje");
+ }
so simple:
if (empty) { if (!empty) { XXX } else { YYY } }
the first !empty path can never happen. we never got there if its empty. by
extension then the rest of the logic (ny + hh ...) cant be useful so in fact
this code "does nothing" here. those whole section shouldnt not have changed.
similar for the next blob in the patch... the !empty check:
if (eina_rectangle_coords_inside(en->region_vp,
nx, ny))
- edje_object_signal_emit(en->handler_start,
"edje,handler,show", "edje");
+ {
+ if (!eina_rectangle_is_empty(en->region_ly) &&
+ ((ny + hh) > (en->region_ly->y +
en->region_ly->h)))
+ edje_object_signal_emit(en->handler_start,
"edje,handler,show,top", "edje");
+ else
+ edje_object_signal_emit(en->handler_start,
"edje,handler,show,bottom", "edje");
+ }
}
is useless as coords cant be inside an empty rect. :) so dont need the first
check. :) same for the next blob of similar changes below. :)
i've fixed this to now be "logical" and not conflict patch-wise. :) though in
my local tree.
> Dear all,
> This is the extension patch for the previous 'selection handler' and
> 'viewport check' in entry.
>
> Selection handlers will be displayed on the top or bottom of the selection
> block according to the position of the layout that is contained in
> conformant. Elm_entry queries the layout region from the geometry of the
> conformant that contains the entry itself, and pass the information to
> edje_entry as the same way with the viewport region.
>
> Because this patch is based on the previous patches, apply the next patches
> first and this later.
> - selection handler patch : [E-devel] [Patch] [Ejde, Elementary] added
> selection handler feature to entry
> - viewport check patch : [E-devel] [Patch] [Ejde, Elementary] added viewport
> check to entry selection handler
>
> Please review this patch and feel free to give me feedbacks when you have
> questions.
>
> Regards,
> --------------
> Myungjae Lee
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) [email protected]
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
