On Friday, September 7, 2012, Daniel Juyung Seo wrote: > Ok I changed my mind. > Returning NULL would not help users to detect a bug because list can be > NULL. > > This Is the most non sense comment ever. Why a programmer that giver the function the INCORRECT parameters would be checking the error code??!??!!??!!?!!?
Seriously this is also technically wrong in other ways: - NULL list is valid, never change this - sort without a compare is no sort. Just don't change the list. Return it - eina list reports errors as Eina_Error not return > So the first one! > Now I am in a 'fix the documentation' mood. > > Daniel Juyung Seo (SeoZ) > > On Fri, Sep 7, 2012 at 2:45 PM, Daniel Juyung Seo > <[email protected]<javascript:;>> > wrote: > > Well... > > > > According to the existing code, it returns 'list' when func is NULL. > > According to the documentation, it returns NULL when func is NULL. > > > > Fighting between code and documentation :) > > This is a matter of choice imho. > > > > I prefer the second one. > > > > Of course, we should print a huge amount of error messages in either > case. > > > > Daniel Juyung Seo (SeoZ) > > > > > > On Fri, Sep 7, 2012 at 2:13 PM, Sungho Kwak > > <[email protected]<javascript:;>> > wrote: > >> Huh, where is my attached file? :( > >> > >> 2012/9/7 곽성호 <[email protected] <javascript:;>> > >> > >>> Hi, > >>> > >>> I found 2 bugs on eina_list.c > >>> 1) eina_list_sort : if func or list is NULL, function returns NULL > (on > >>> documentation). I changed code to check to check both of func and list > with > >>> well-known pattern. > >>> 2) eina_list_accessor_new : if list is NULL, function nreturn NULL > (on > >>> documentation). I add NULL check routine. > >>> > >>> Thanks. > >>> > >>> Sincerely, > >>> Sungho Kwak. > >>> > >>> > ------------------------------------------------------------------------------ > >>> Live Security Virtual Conference > >>> Exclusive live event will cover all the ways today's security and > >>> threat landscape has changed and how IT managers can respond. > Discussions > >>> will include endpoint security, mobile security and the latest in > malware > >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > >>> _______________________________________________ > >>> enlightenment-devel mailing list > >>> [email protected] <javascript:;> > >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >>> > >> > >> > ------------------------------------------------------------------------------ > >> Live Security Virtual Conference > >> Exclusive live event will cover all the ways today's security and > >> threat landscape has changed and how IT managers can respond. > Discussions > >> will include endpoint security, mobile security and the latest in > malware > >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > >> _______________________________________________ > >> enlightenment-devel mailing list > >> [email protected] <javascript:;> > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] <javascript:;> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
