On Mon, 10 Sep 2012 17:39:58 +0900 Daniel Juyung Seo <seojuyu...@gmail.com> said:
> No, this patch does not do anything useful. > I am really sorry but we should not accept this kind of patch. > > As far as I know, Myung-jae implemented the feature without adding > BLOCK_HANDLE. > http://marc.info/?l=enlightenment-devel&w=2&r=1&s=+[Ejde%2C+Elementary]+&q=b > > But the patch was pending for one and half months due to EFL 1.7 release. > So once he resend the patch and if the patch is committed, this kind > of hack should be removed. > > Should I revert this now or leave it and remove it later? > I bet we should keep the code clean. eeek. it got committed. there was no response for etrunko's question... so i thought it was abandoned.! indeed i rejected a similar style patch adding a dummy api for something yet to be in upstream (magnifier stuff). efl is not a dumping ground for every failed experiment by some company that didnt push changes up early. i understand the desire to add just compat api/tag handling BUT it isn't appropriate here. if the feature was abandoned or not yet accepted upstream then fix the code/theme that uses an experimental "local only patch". imho the right policy is to reject such patches always. sure - a full FEATURE that was provided as a patch and that is later found not to be useful, if we do a release with that feature/api even if not useful, we can't go back and remove it, but we shouldn't ADD api's or tags in that from the very beginning are "not useful". > Daniel Juyung Seo (SeoZ) > > > On Tue, Aug 28, 2012 at 1:07 AM, Eduardo Lima (Etrunko) > <ebl...@gmail.com> wrote: > > Hi Alex, > > > > Why is this needed? And could you please add the BLOCK_HANDLE entry in > > the documentation? > > > > Best regards, Etrunko. > > > > On Mon, Aug 27, 2012 at 2:40 AM, <zhiwen...@linux.intel.com> wrote: > >> From: Alex Wu <zhiwen...@linux.intel.com> > >> > >> --- > >> trunk/edje/src/bin/edje_cc_handlers.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/trunk/edje/src/bin/edje_cc_handlers.c > >> b/trunk/edje/src/bin/edje_cc_handlers.c index eb91ed4..b0b2c26 100644 > >> --- a/trunk/edje/src/bin/edje_cc_handlers.c > >> +++ b/trunk/edje/src/bin/edje_cc_handlers.c > >> @@ -3627,6 +3627,7 @@ st_collections_group_parts_part_select_mode(void) > >> current_part->select_mode = parse_enum(0, > >> "DEFAULT", > >> EDJE_ENTRY_SELECTION_MODE_DEFAULT, "EXPLICIT", > >> EDJE_ENTRY_SELECTION_MODE_EXPLICIT, > >> + "BLOCK_HANDLE", > >> EDJE_ENTRY_SELECTION_MODE_DEFAULT, NULL); > >> } > >> > >> -- > >> 1.7.9.5 > >> > >> > >> ------------------------------------------------------------------------------ > >> Live Security Virtual Conference > >> Exclusive live event will cover all the ways today's security and > >> threat landscape has changed and how IT managers can respond. Discussions > >> will include endpoint security, mobile security and the latest in malware > >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > -- > > Eduardo de Barros Lima ◤✠◢ > > ebl...@gmail.com > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
