On Fri, 14 Sep 2012 10:49:28 +0900 (KST) ChunEon Park <[email protected]> said:
nb - u replied to the wrong mail - but i know which one you meant to reply to :) > I asked Shlipa to send this patch made by herself. > > I will review this. :3 > > ------------------------------------ > -Regards, Hermet- > > -----Original Message----- > From: "Carsten Haitzler"<[email protected]> > To: "Enlightenment developer > list"<[email protected]>; Cc: "PRINCE KUMAR > DUBEY"<[email protected]>; Sent: 2012-09-13 (목) 20:53:39 > Subject: Re: [E-devel] [Patch] [Elementary] Support for circular effect in > elm_diskselector, in case scroller's bounce effect is disabled. > > On Thu, 13 Sep 2012 10:23:40 +0000 (GMT) PRINCE KUMAR DUBEY > <prince.dubey>@samsung.com> said: > > thanks! yes - this fixes it. tbh i'm not happy with diskselector in general, > but that's another topic. in svn this goes! :) thanks! (also backported) > > > Hi, > > > > Can someone please review the attached patch created by Sumanth. > > > > [Issue Details] : > > elm_diskselector_round_enable_set() API is not working, if elm_scroller's > > bounce effect is disabled. > > > > [Root cause] : > > For diskselector circular effect, the boundary checking is done based on > > scroller's geometry. If bouncing effect is disabled in elm_scroller, its > > geometry can lie between 0 on left and CHILD_SIZE on right but it can never > > go beyond that point. Unless the scroller's geometry goes beyond its child > > (here, elm_box) size, diskselector cann't trigger the circular effect. > > > > [Change Description] : > > For diskselector items circular effect, the boundary checking is performed > > at the left/right edges of its child, elm_box. Once the scroller reaches to > > the left/right edge of box or goes beyond that point, circular effect will > > be triggered. > > > > [Signed-Off-By] Sumanth Krishna ([email protected]) > > > > Thank You. > > Regards, > > Prince > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ > Got visibility? > Most devs has no idea what their production app looks like. > Find out how fast your code is with AppDynamics Lite. > http://ad.doubleclick.net/clk;262219671;13503038;y? > http://info.appdynamics.com/FreeJavaPerformanceDownload.html > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
