* EDBus as a namespace is really annoying to type and should be Edbus by the EFL coding standards anyway. this applies to headers, types, and anything else which uses improper capitalization * EDBus_Proxy should be Edbus_Interface since anyone who knows dbus code and sees proxy will go WTF since that's not even a dbus keyword. this also applies to the entire edbus_proxy namespace. it may be the case that it's proxying an interface, but there's no need to add confusing unrelated terminology here * edbus_connection_cb_free namespace should be edbus_connection_free_cb * EDBUS_CONNECTION_EVENT_NAME_OWNER_CHANGED is commented out...I assume this will be usable later? * imo all the random #defines which share namespaces should be enums * if the point was to get away from libdbus, why does this still use the exact same bad methodology as libdbus, such as EDBus_Message_Iter? why do we not have serialization from/to native EFL types, or at least something like serializing to Eina_Value? * EDBUS_ARGS looks neat, bonus points for this * have you considered adding an error param to message callbacks to simplify checking for errors every time?
On Mon, Sep 17, 2012 at 10:17 PM, Lucas De Marchi < [email protected]> wrote: > On Mon, Sep 17, 2012 at 5:41 PM, Enlightenment SVN > <[email protected]> wrote: > > Log: > > Add new edbus library, aka e_dbus v2 > > hey, I've just committed the new edbus library. > > Contrary to the previous e_dbus, this is a complete wrapper on > libdbus. No more "#include <dbus/dbus.h>" in our applications. The > idea is that in future we may be able to ditch libdbus too. > > What's being committed today is a big bootstrap of the library. I > decided to squash all commits and commit to svn - the history in the > early days of the library is not so interesting... from now on it will > follow a regular 1 commit per feature/bug-fix. > > It's working on our basic use-cases, but it's still a working in > progress and we are polishing the API. Feedback is very much welcome. > Some functions may disappear if we find it's not really necessary, > others may be added, etc. Until release, anything can happen - don't > be fooled by its version number - it's 1.7.x only to sync with the > rest of EFL. > > > Kudos where it's due: most of the library was written by José Roberto > de Souza and another great fraction by Gustavo Barbieri. I and Leandro > were mostly reviewing and fixing some bugs. > > José is now porting several of our applications to the new library so > we can polish the API and at the same time get the applications to use > it. > > > Please take a look, send bug reports, patches, etc. > > If it's completely broken for you, complain with zehortigoza or > demarchi in #edevelop :-) > > > Cheers, > Lucas De Marchi > > > > > > > > > > > Author: lucas > > Date: 2012-09-17 13:41:05 -0700 (Mon, 17 Sep 2012) > > New Revision: 76775 > > Trac: http://trac.enlightenment.org/e/changeset/76775 > > > > Added: > > trunk/edbus/ trunk/edbus/.gitignore trunk/edbus/AUTHORS > trunk/edbus/Makefile.am trunk/edbus/autogen.sh > trunk/edbus/configure.actrunk/edbus/doc/ trunk/edbus/doc/Doxyfile.in > trunk/edbus/doc/Makefile.am > trunk/edbus/doc/e.css trunk/edbus/doc/examples.dox > trunk/edbus/doc/foot.html trunk/edbus/doc/head.html trunk/edbus/doc/images/ > trunk/edbus/doc/images/e.png trunk/edbus/doc/images/edoxy.css > trunk/edbus/doc/images/foot_bg.png trunk/edbus/doc/images/head_bg.png > trunk/edbus/doc/images/menu_bg.png > trunk/edbus/doc/images/menu_bg_current.png > trunk/edbus/doc/images/menu_bg_hover.png > trunk/edbus/doc/images/menu_bg_last.png > trunk/edbus/doc/images/menu_bg_unsel.png > trunk/edbus/edbus.pc.intrunk/edbus/m4/ trunk/edbus/m4/ac_attribute.m4 > trunk/edbus/m4/ac_valist.m4 > trunk/edbus/m4/efl_compiler_flag.m4 trunk/edbus/m4/efl_doxygen.m4 > trunk/edbus/src/ trunk/edbus/src/examples/ > trunk/edbus/src/examples/banshee.c trunk/edbus/src/examples/client.c > trunk/edbus/src/examples/complex_types.c > trunk/edbus/src/examples/complex_types_server.c > trunk/edbus/src/examples/connman-list-services.c > trunk/edbus/src/examples/ofono-dial.c trunk/edbus/src/examples/server.c > trunk/edbus/src/lib/ trunk/edbus/src/lib/EDBus.h > trunk/edbus/src/lib/edbus_connection.h trunk/edbus/src/lib/edbus_core.c > trunk/edbus/src/lib/edbus_freedesktop.c > trunk/edbus/src/lib/edbus_freedesktop.h trunk/edbus/src/lib/edbus_message.c > trunk/edbus/src/lib/edbus_message.h trunk/edbus/src/lib/edbus_object.c > trunk/edbus/src/lib/edbus_object.h trunk/edbus/src/lib/edbus_pending.c > trunk/edbus/src/lib/edbus_pending.h trunk/edbus/src/lib/edbus_private.h > trunk/edbus/src/lib/edbus_private_types.h trunk/edbus/src/lib/edbus_proxy.c > trunk/edbus/src/lib/edbus_proxy.h trunk/edbus/src/lib/edbus_service.c > trunk/edbus/src/lib/edbus_service.h > trunk/edbus/src/lib/edbus_signal_handler.c > trunk/edbus/src/lib/edbus_signal_handler.h ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
