Thanks, for check. I thought that if Magic check for timer is done after lock, the same should be done for in. But you are right, checking after lock does not make sense, it is better to do that before. I had fixed that, but to be clear I had also fixed ecore_timer_precision_set function in same way.
Regards, -----Original Message----- From: Vincent Torri [mailto:vincent.to...@gmail.com] Sent: 17 wrzeĊnia 2012 19:33 To: Enlightenment developer list Subject: Re: [E-devel] [Patch] [Ecore] Protection for giving below zero values for ecore_poll and ecore_timer On Mon, Sep 17, 2012 at 5:51 PM, Patryk Kaczmarek <patry...@samsung.com> wrote: > Hi again, > > > > Please also check attached patch for ecore_timer_interval_set and > ecore_poller_poll_interval_set. > > It checks if given time is not zero or below zero. > in the second part, why putting the check of 'in' after the lock ? Vincent ---------------------------------------------------------------------------- -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
0001-Protection-for-giving-below-zero-val.patch
Description: Binary data
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
