As ecore is implemented now it should be true, but in theory it can be false for large drop objects which needs time to transfer (if I remember correctly). If we don't plan to implement this feature maybe it should be cleaned up?
Den 18. sep. 2012 kl. 15:20 skrev "Enlightenment SVN" <no-re...@enlightenment.org>: > Log: > ignore the completed flag on dnd-finished events since this (SHOULD be) > always true; fixes bug where windows could be stuck in a never-ending drag > and no longer respond to user input > > > Author: discomfitor > Date: 2012-09-18 06:20:11 -0700 (Tue, 18 Sep 2012) > New Revision: 76818 > Trac: http://trac.enlightenment.org/e/changeset/76818 > > Modified: > trunk/e/src/bin/e_dnd.c > > Modified: trunk/e/src/bin/e_dnd.c > =================================================================== > --- trunk/e/src/bin/e_dnd.c 2012-09-18 13:05:20 UTC (rev 76817) > +++ trunk/e/src/bin/e_dnd.c 2012-09-18 13:20:11 UTC (rev 76818) > @@ -1377,14 +1377,20 @@ > } > > static Eina_Bool > -_e_dnd_cb_event_dnd_finished(void *data __UNUSED__, int type __UNUSED__, > void *event) > +_e_dnd_cb_event_dnd_finished(void *data __UNUSED__, int type __UNUSED__, > void *event __UNUSED__) > { > +/* > + * this is broken since the completed flag doesn't tell us anything with > current > + * ecore-x and results in never-ending dnd operation which breaks the window > + * 18 September 2012 > + * BORKER CERTIFICATION: BRONZE > + * -discomfitor > Ecore_X_Event_Xdnd_Finished *ev; > > ev = event; > > if (!ev->completed) return ECORE_CALLBACK_PASS_ON; > - > +*/ > if (_drag_current) > { > E_Drag *tmp; > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
